Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timer icon #278

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Add timer icon #278

merged 1 commit into from
Nov 19, 2021

Conversation

marcellamaki
Copy link
Member

Description

Makes the "timer" icon available in KDS

Issue addressed

Needed for Kolibri Practice Quiz renderer and timer

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change has been added to the changelog

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Post-merge updates and tracking

  • Learning Platform update PR is submitted
  • Learning Platform update PR is merged
  • Studio update PR is submitted
  • Studio update PR is merged
  • Data Portal update PR is submitted
  • Data Portal update PR is merged

Comments

nucleogenesis
nucleogenesis approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@marcellamaki marcellamaki merged commit 5710567 into learningequality:main Nov 19, 2021
@marcellamaki marcellamaki deleted the add-timer branch November 19, 2021 22:05
@indirectlylit
Copy link
Contributor

just a reminder to update the changelog next time:

image

@indirectlylit indirectlylit mentioned this pull request Nov 23, 2021
Merged
14 tasks
@indirectlylit
Copy link
Contributor

adding a reference in subsequent PR here: #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis approved these changes

@indirectlylit indirectlylit Awaiting requested review from indirectlylit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcellamaki @indirectlylit @nucleogenesis