-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Practice quiz renderer #8645
Practice quiz renderer #8645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! THANK YOU SO MUCH for doing this. Did some quick manual QA based on your summary:
- As learner, am able to take practice quiz, able to retry (from modal), and can see what I've done after I have submitted a practice quiz
Questions:
- It should be that if I submit, then I see the "completed" icon on the content card, and when I practice again (even if I haven't answered any questions), I no longer see the "completed" icon, but instead it goes back to being blank - is this correct? (below, my "Recognize fractions" practice quiz is in progress, but I've exited)
- Is the plan that the additional UI changes for renderer in full screen (the timer, namely), be rebased on top of this?
- There is a todo attached to this PR: Integration with new API endpoint for fetching tries data; should that be a separate issue, or is this something to be tracked here?
Timer will be added as a separate PR. The front end for it is almost done, and once I push my PR for that (probably tomorrow morning) Richard will make one backend change to "reset" the time spent based on which try you are on (right now, it just resumes and adds on to the time from the previous try). ETA: cancel that, changes have been included here |
bde934c
to
f2f868c
Compare
f2f868c
to
4c12298
Compare
I think we should change the progress to a 'peppercorn' progress once you click retry (we do this as soon as you start an exercise similarly) so that it shows that you have started it at least, rather than being completely blank.
I added this assuming that we'd have the new API fairly soon as I knew that @bjester had already made progress on it - but we can do this in follow up instead. |
4c12298
to
4326777
Compare
I have updated the progress setting for the QuizRenderer so it should actually show some progress as long as any interaction has happened, and should show progress that is roughly correlated with the number of questions answered. |
Test results from the current progress (EXE asset on Windows 7, tested in Firefox and Chrome)
There is also an annoying delay when the final Submit button is pressed from the modal, it seems as if nothing is happening, and this lag invites the learner to click the Submit button again. Not seeing any errors in the console, but including logs just in case: |
89644f9
to
3d7230d
Compare
Status update of what's covered (not Gherkin official!):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. I took a practice quiz multiple times and everything looks good too
fd2c869
to
0ccaede
Compare
0ccaede
to
11f946e
Compare
…te check quiz status
11f946e
to
d23374c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Summary
References
Fixes #8622
Fixes #8520
Fixes #8511
Fixes #8538
Fixes #8509
Fixes #8540
Fixes #8508
Fixes #8510
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)