Adds props/computed props to mixin for KContentRenderer #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edProgress computed props
rtibbles
reviewed
Apr 22, 2021
There was a problem hiding this comment.
Looks good - thinking it will be useful to implement the solution to learningequality/kolibri#7970 in parallel to this to make sure it has everything it needs?
|
FYI in my PR #223 I added support for extracting JSDocs from the
I did not try documenting the props and method yet |
…ystem into kcontentrenderer with fix to read epubs
9 tasks
|
@indirectlylit Nice! I'll make an issue to update this particular component once everything is merged in! Thanks! |
rtibbles
reviewed
May 13, 2021
rtibbles
approved these changes
May 19, 2021
|
looks great! Just a reminder to file an issue for writing prop jsdocs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
timeSpent,durationprops andforceTimeBasedProgress,durationBasedcomputed props so that we can refactor Kolibri content renderers to use unified time-tracking.Issue addressed
Addresses #214
Steps to test
Currently, to test this PR, you'll have to use learningequality/kolibri#8037 in order to make sure the new props and computed props are working (see tech-debt items below for details).
(optional) Implementation notes
At a high level, how did you implement this?
Added props and computed props to the mixin used by
KContentRenderer.Does this introduce any tech-debt items?
There are currently no tests in KDS to address the use of these props and computed props; however, tests exist on the individual renderers in Kolibri.
Reviewer guidance
Comments