Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work on documenting component api #223

Merged
merged 26 commits into from
May 3, 2021

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Apr 21, 2021

  • Removes or enables all disabled ToC items
  • Adds many component pages
  • Improves component jsdocs

@indirectlylit indirectlylit marked this pull request as draft April 21, 2021 16:13
@indirectlylit indirectlylit changed the title work on api work on documenting component api Apr 21, 2021
@indirectlylit indirectlylit marked this pull request as ready for review April 23, 2021 01:15
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew this is a lot of updates! It looks good - thanks for getting those final few inactive pages set up @indirectlylit. I also really appreciate the way that you added or updated some comments - clear and helpful for those of us who are newer. I think this is good to go but would appreciate a quick pass from one other person just to make sure I haven't missed anything critical

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing. Great work @indirectlylit - this is a huge improvement for the docs overall.

@indirectlylit
Copy link
Contributor Author

thanks guys! still a lot more to do, but glad to keep it moving forward

@indirectlylit indirectlylit merged commit 54d58a0 into learningequality:v0.2.x May 3, 2021
@indirectlylit indirectlylit deleted the toc branch June 7, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants