-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
work on documenting component api #223
Conversation
indirectlylit
commented
Apr 21, 2021
•
edited
Loading
edited
- Removes or enables all disabled ToC items
- Adds many component pages
- Improves component jsdocs
fixes hot reload of API edits, broken in b00c62a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew this is a lot of updates! It looks good - thanks for getting those final few inactive pages set up @indirectlylit. I also really appreciate the way that you added or updated some comments - clear and helpful for those of us who are newer. I think this is good to go but would appreciate a quick pass from one other person just to make sure I haven't missed anything critical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing. Great work @indirectlylit - this is a huge improvement for the docs overall.
thanks guys! still a lot more to do, but glad to keep it moving forward |