Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video-js and VTT.js upgrade #5349

Merged
merged 6 commits into from
Dec 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions .travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ assets:
KALITE_HOME=.kalite_dist_tmp bin/kalite manage migrate
mkdir -p kalite/database/templates/
cp .kalite_dist_tmp/database/data.sqlite kalite/database/templates/
bin/kalite manage retrievecontentpack download en --minimal --foreground --template
# bin/kalite manage retrievecontentpack download en --minimal --foreground --template

release: dist man
ls -l dist
Expand Down
1 change: 1 addition & 0 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies:
test:
override:
- make assets
- bin/kalite manage retrievecontentpack download en --minimal --foreground --template
- make docs
- kalite start --traceback -v2
- kalite status
Expand Down
1 change: 1 addition & 0 deletions docs/installguide/release_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Bug fixes
* Redirect to front page if user logs in from the signup page :url-issue:`3926`
* Progress bar missing when decimals in progress percentage :url-issue:`5321`
* Missing cache invalidation for JavaScript meant client-side breakage: Upgraded CherryPy HTTP server to 3.3.0 :url-issue:`5317`
* **Dev** Loading subtitles now works in ``bin/kalite manage runserver --settings=kalite.project.settings.dev``


Known issues
Expand Down
2 changes: 1 addition & 1 deletion kalite/distributed/static/js/distributed/video/views.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var _ = require("underscore");
var BaseView = require("base/baseview");
var Handlebars = require("base/handlebars");

var vtt = require("videojs-vtt.js"); // Must precede video.js
var vtt = require("vtt.js"); // Must precede video.js
global.WebVTT = vtt.WebVTT; // Required to be in the global scope by video.js

var _V_ = require("video.js");
Expand Down
4 changes: 4 additions & 0 deletions kalite/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,11 @@

# Content path-related settings
CONTENT_ROOT = os.path.realpath(os.getenv('KALITE_CONTENT_ROOT', getattr(local_settings, "CONTENT_ROOT", os.path.join(USER_DATA_ROOT, 'content'))))
SRT_ROOT = os.path.join(STATIC_ROOT, "srt")
if not os.path.exists(CONTENT_ROOT):
os.makedirs(CONTENT_ROOT)
if not os.path.exists(SRT_ROOT):
os.makedirs(SRT_ROOT)
CONTENT_URL = getattr(local_settings, "CONTENT_URL", "/content/")


Expand Down Expand Up @@ -358,6 +361,7 @@
STATICFILES_DIRS = (
os.path.join(PACKAGE_PATH, 'static-libraries'),
USER_STATIC_FILES,
('srt', SRT_ROOT)
)

DEFAULT_ENCODING = 'utf-8'
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@
"through": "2.3.8",
"underscore": "1.8.3",
"url": "0.10.3",
"video.js": "5.8.0",
"videojs-vtt.js": "0.12.1",
"video.js": "git://github.com/learningequality/video.js.git#firefox50-dist",
"vtt.js": "git://github.com/benjaoming/vtt.js.git#cuestuff",
"watchify": "3.4.0"
}
}