-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video-js and VTT.js upgrade #5349
Video-js and VTT.js upgrade #5349
Conversation
Current coverage is 51.02% (diff: 66.66%)@@ develop #5349 diff @@
==========================================
Files 142 142
Lines 7482 7485 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 3822 3819 -3
- Misses 3660 3666 +6
Partials 0 0
|
Interestingly, this PR starts work on removing the minimal English content pack so also addresses #5318 |
On another note, the current patched git forks of video.js + vtt.js require the build systems to be able to fetch stuff in package.json with git -- no problem on Linux, but could cause issues on Mac / Windows build systems.. I can fix this if necessary @mrpau-eduard @mrpau-richard so let me know if |
Summary
Fixes #5347
It became a bit of an assorted fixes and improvements PR, so here's an overview:
DEBUG=True
andrunserver
assets
make target..travis.yml