Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't invalidate caches on the Mac, and warn users that they need to restart after video download #4510

Closed
wants to merge 1 commit into from
Closed

Don't invalidate caches on the Mac, and warn users that they need to restart after video download #4510

wants to merge 1 commit into from

Conversation

rtibbles
Copy link
Member

edit by @cpauya: fixes #4483

@rtibbles rtibbles added this to the 0.15.0 milestone Sep 25, 2015
@rtibbles
Copy link
Member Author

Fixes #4483

@mrpau-richard
Copy link
Contributor

@rtibbles & @cpauya I tested this PR on OS X Yosemite, and the warning message does not show after the video download finished.

screen shot 2015-09-28 at 3 57 17 pm

screen shot 2015-09-28 at 3 57 39 pm

I got this browser console error when downloading videos.
screen shot 2015-09-28 at 4 00 42 pm

@cpauya
Copy link
Contributor

cpauya commented Sep 28, 2015

@amodia The "warning message" is supposed to tell the Mac user to restart the server after downloading a video and NOT "the warning message does not show after the video download finished." as you expected.

Did it show the warning message?

@djallado
Copy link
Contributor

I build mac installer based on this PR and I can see the message.
Here's the screenshot:

screen shot 2015-09-28 at 5 58 37 pm

The message appear when I click on Video tab.

@cpauya
Copy link
Contributor

cpauya commented Sep 28, 2015

Ok, got the message running here.

screenshot 2015-09-28 18 46 53

Merging this now.

@cpauya cpauya closed this Sep 28, 2015
@cpauya cpauya removed the has PR label Sep 28, 2015
@cpauya cpauya mentioned this pull request Sep 28, 2015
Closed
@mrpau-richard
Copy link
Contributor

Yeah, It's also working on me. I just removed the" KALITE_PYTHON" environment and setup new virtualenv.
screen shot 2015-09-28 at 7 17 57 pm

@cpauya cpauya mentioned this pull request Sep 28, 2015
Merged
@cpauya
Copy link
Contributor

cpauya commented Sep 28, 2015

Oh, there's a Reopen button! Damn I already created #4518. :(

@aronasorman aronasorman mentioned this pull request Oct 2, 2015
Closed
benjaoming
benjaoming reviewed Oct 2, 2015
View reviewed changes
kalite/updates/views.py
@@ -32,7 +34,7 @@ def update_videos(request, max_to_show=4):
if getattr(settings, 'USING_RASPBERRY_PI', False):
messages.warning(request, _('For low-powered devices like the Raspberry Pi, please download less than 25 videos at a time.'))

if DO_NOT_RELOAD_CONTENT_CACHE_AT_STARTUP:
if DO_NOT_RELOAD_CONTENT_CACHE_AT_STARTUP or sys.platform == 'darwin':

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@rtibbles rtibbles deleted the macs_be_whack_yo branch March 2, 2016 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aronasorman aronasorman

Labels
release blocker
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rtibbles @mrpau-richard @cpauya @djallado @benjaoming @aronasorman