-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar is not updating downloaded videos #4483
Comments
if you restart the server, will those videos be available on the sidebar? |
Testing a restart of the server logged in as admin, the previously downloaded did show up correctly but new videos downloaded afterwards did not show up. Roughly 30 minutes later returning from our standup meeting I found that I had been logged out of the server upon logging back in the videos I had just downloaded where listed. I hope this may help solve the problem? |
I manually added I tried the following but no dice too:
The only solution so far is to restart the server after downloading videos so they are not greyed-out in the sidebar. I thought adding Anything I missed perhaps? /cc: @rtibbles @aronasorman |
I also observed that after start the server, if you don't go to the learn page just yet, instead go to download some videos and then go to learn page, the sidebar will initiate( like it always does for the first time open the sidebar) and all downloaded videos shown up correctly. |
@66eli77 That is exactly what I did here but I am having a completely different outcome using the MAC installer not GIT? |
This seems to be Mac specific - I cannot replicate on Ubuntu/Chrome from git install 0.15.x. |
@cpauya, @66eli77 and I replicated this on his macbook. We set this value to be unconditionally false, and now we get the expected behaviour. I'm not sure what to do, perhaps we should remove this mac-specific hack, and see how we can avoid making KA Lite crash as per #3704? |
The frustrating is that any fix we make for this will only be for 0.15, as @rtibbles' cache invalidation PR doesn't use in memory variables for caching. |
Yeah, so this is definitely a threading issue - the 'cache_invalidation' is happening inside the subprocess, so its changes to the global variables are not affecting the actual ones used by KA Lite. |
No fix has been made yet for this issue, @EdDixon, so it is not clear it's related. |
Resolution was to just add a warning for Mac users, indicating that they need to restart their server once they download videos. |
Fixed in #4510 -- now have warning for users of Mac server to "restart server after downloading videos". |
Re-opening this in reference to Mac installer to use DO_NOT_RELOAD_CONTENT_CACHE_AT_STARTUP |
This was reopened, so we can use |
Punting to 0.16. Where it is fixed. Closing. |
Did you add it after or before |
I added it after the import line, at the end of the |
@cpauya that should work :) You can always test it with:
|
Apparently a problem in 0.14.2. Will check before release. |
User error. |
While testing the current 0.15 MAC develop installer, I noticed that after having downloaded videos as the admin user then going back to the side bar the videos were not listed. I then logged out of admin and logged in as a student still the videos which where downloaded and reflected as downloaded in the video tree where not available to either user using the sidebar.
The text was updated successfully, but these errors were encountered: