Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4382 -- we are MIT licensed #4384

Merged
merged 1 commit into from
Sep 7, 2015
Merged

Fix #4382 -- we are MIT licensed #4384

merged 1 commit into from
Sep 7, 2015

Conversation

benjaoming
Copy link
Contributor

@aronasorman
Copy link
Collaborator

We probably need to include the license on top of each source file too at some point :)

@aronasorman aronasorman added this to the 0.14.x bugfixes milestone Sep 7, 2015
@jamalex
Copy link
Member

jamalex commented Sep 7, 2015

Cool, thx -- I think it's best to have it MIT for now, but we could revisit earlier discussions we had (a couple years ago) about switching to a copyleft license like GPL, and examine how it might affect partnerships, strategy, or other practical issues.

@jamalex
Copy link
Member

jamalex commented Sep 7, 2015

I'm assuming the OfflineGenerationError: You have offline compression enabled but key "9818b417fc796fd10733c626222e7217" is missing from offline manifest. You may need to run "python manage.py compress". error is unrelated. :P Merging!

jamalex added a commit that referenced this pull request Sep 7, 2015
@jamalex
Merge pull request #4384 from benjaoming/mit-license
5d6ddd7 
Fix #4382 -- we are MIT licensed
@jamalex jamalex merged commit 5d6ddd7 into learningequality:0.14.x Sep 7, 2015
@jamalex jamalex removed the has PR label Sep 7, 2015
@jamalex jamalex mentioned this pull request Sep 7, 2015
Closed
@benjaoming
Copy link
Contributor Author

@jamalex that's one of the many many test failures I'm trying to get rid of in #4385 and have finally succeeded in running tests locally.

@benjaoming benjaoming mentioned this pull request Sep 8, 2015
Merged
@benjaoming benjaoming deleted the mit-license branch September 28, 2015 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jamalex jamalex

Labels
None yet
Projects
None yet
Milestone
0.14.x bugfixes
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaoming @aronasorman @jamalex