-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/2271 export csv data quality issues #2742
Hotfix/2271 export csv data quality issues #2742
Conversation
@rtibbles you may want to take a look as well. |
Instructions to get new changes in CSV Report:
In our manual test Video Log is already Fixed. Try to check export CSV with your actual data. |
Hi @aronasorman. We set @mikewray. In our last commit, we fixed the issue in |
Hi there. Can you confirm the total_hours will work in any circumstance, so can cross months e.g. i.e. an inclusive report for the whole period of existence will equal the sum of two or more reports. I've been doing all this testing through the central server, the data derives from 3 Rpi's in the field in Zambia. Can you put this change into staging or live and I can test it there? I don't have the test data on my laptop and think it will take me while to find an old data set that will work for this test. Much easier to work with data I know and I can run the same tests I've been doing. Thanks for your work on this |
Code looks good. Merging so we can test it to the central server. |
…ty-issues Hotfix/2271 export csv data quality issues
Just noticed that I merged this to master!!! Noooo!! Next time, please target release-0.12.0. |
Manually merged to release-0.12.0 |
Let me know when I can test on CS. Tx!
|
Hi @mikewray! Should be within the next 4 hours. I'm just waiting for the tests to pass, then will merge it to the central server and update it. |
I just ran a quick test on central server and looks like changes not taken effect there as getting same results as previous for both hours and videos column. Tx again - let me know. |
Hi @mikewray - I think @aronasorman hasn't updated the central server yet. We'll keep you posted. |
Hi @mikewray, I've updated the central server, so you should be able to test it now. Once we've got the confirmation from you I'll issue the 0.12.9 update and you should be able to download it! |
I'd test in my |
HI - just run similar to test to the one I did before off central server. Data is exactly the same as previous unfortunately, see summary below. I'm happy to email login details to do the tests themselves to replicate. Just in case of consequence, the data comes from Rpi with version 0.12.5 on them. |
Hi mike, please try to check at the staging server at http://staging.learningequality.org/organization/ because that's what @aronasorman has updated. I don't know if staging has your data but maybe you can upload/sync some sample data for your test? @djallado will issue a fix for central server on another PR where the video logs does not include the data for the end date. |
I have your login credentials and have tried it also. We will try to sync some sample data on staging under my sample organization to check too. |
I'm observing the same issues with my data on both distributed and staging, was something meant to have changed? Tx! |
@aronasorman.
Issue: #2271 export csv data quality issues
Video Log
is already Fixed.Total Videos
in CSV report is now the same withVideos Viewed
in web viewFor now, narrowing out date range in less than a month to generate CSV report causes
total_hours
column different from web viewLogin Time
.Reason:
UserLogSummary
is at least one month.Recommendation:
We will use
UserLog
instead ofUserLogSummary
.Problems of using
UserLog
:generaterealdata
becausegeneraterealdata
generates exercise into a singleUserLog