Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build PyRun to include the multiprocessing module. #100

Closed
cpauya opened this issue Jul 17, 2015 · 1 comment
Closed

Build PyRun to include the multiprocessing module. #100

cpauya opened this issue Jul 17, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@cpauya
Copy link
Contributor

cpauya commented Jul 17, 2015

Branch master
Target 0.15.0
Current Behavior
Any calls to fle_utils.django_utils.command.call_command_subprocess() under OSX will use the CommandProcess class that uses the multiprocessing module.

As per eGenix's documentation on PyRun, they don't include the _multiprocessing module so calls to such will crash the ka-lite server.
screenshot 2015-07-17 01 52 37

Manifestations of failures include:

  • video downloads fails
  • language pack download fails
  • calls to cron, securesync, device registrations fails

Expected Behavior
We must build PyRun to include the multiprocessing module.

Possible Solution/s
For now, use the subprocess module like the one on call_outside_command_with_output().

Related Issues
Here are the related issues affected by this:

References
These references are here to confirm that multiprocessing with Django must be done carefully. They suggests to close the database connection before spawning a child process but that's not our intended solution here:

@cpauya
Copy link
Contributor Author

cpauya commented Mar 28, 2016

As of 0.16, the issues reported here like the video and language pack downloads are already working.

Let's re-open this in case the issue pops-up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant