Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Pyrun on OS X Installer and replace it with virtualenv. #98

Closed
djallado opened this issue Jul 15, 2015 · 8 comments
Closed

Drop Pyrun on OS X Installer and replace it with virtualenv. #98

djallado opened this issue Jul 15, 2015 · 8 comments
Assignees
Labels
Milestone

Comments

@djallado
Copy link
Contributor

Branch: master (OS X Installer)

Expected Behavior: Download video or update language pack will continue without error.

Current Behavior: There's an error when downloading videos or updating language pack.
Here's the screenshoot:

screen shot 2015-07-15 at 10 38 14 am

Steps to reproduce:

  1. Login as Admin User.
  2. Click Video tab.
  3. Navigate to the topic tree and choose your preferred video to download.
  4. Click on Download new selected video button. Then error will occur like in the screenshot:
    screen shot 2015-07-15 at 10 38 14 am
@jamalex
Copy link
Member

jamalex commented Jul 15, 2015

@benjaoming Is it possible that the cron server isn't getting passed the correct settings, and hence isn't accessing the shared database (the one migrations should already have been run against)?

@djallado
Copy link
Contributor Author

@aronasorman.

Our plan after dropping pyrun:

  1. In our script we will check the minimum python package of 2.7.9+.
  2. If below, then we will prompt the user to to upgrade python.
  3. We will include kalite source also.
  4. Pip packages are included in .dmg.

@benjaoming
Copy link
Contributor

@jamalex could be a settings discrepancy, but only in case the OSX installer does use a custom settings module. As for the latest 0.14.x and develop branches, they are using the fix for the --settings option.

@djallado in case the OSX installer uses one settings module (--settings or DJANGO_SETTINGS_MODULE) for running kalite manage setup, then kalite start has to use the same and vice versa.

@cpauya
Copy link
Contributor

cpauya commented Jul 17, 2015

This is a manifestation of the issue on #100 - we can ignore this for now and close this after #100 is closed.

@cpauya cpauya added the Mac label Jul 17, 2015
@cpauya cpauya self-assigned this Jul 17, 2015
@cpauya cpauya added this to the 0.14.0 milestone Jul 17, 2015
@cpauya cpauya modified the milestones: 0.15.0, 0.14.0 Aug 1, 2015
@cpauya cpauya changed the title Dropping Pyrun on OS X Installer replace it with virtualenv. Drop Pyrun on OS X Installer and replace it with virtualenv. Aug 28, 2015
@cpauya cpauya modified the milestones: 0.16.0, 0.15.0 Sep 4, 2015
@cpauya
Copy link
Contributor

cpauya commented Mar 28, 2016

PyRun will still be used for release 0.16. Moving this to 0.17.

@benjaoming
Copy link
Contributor

Is this going to be using PEX?

@mrpau-richard
Copy link
Contributor

Fixed in 429

@mrpau-richard
Copy link
Contributor

@benjaoming Yeah, We're now using PEX in KA Lite OS X installer closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants