Follow up #501 and #511 with minor fixes #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
force-pushed
the
identity-shutdown-fixes
branch
from
39bd515 to
fc952b3
Compare
borzunov
commented
Oct 11, 2022
| @@ -301,11 +298,10 @@ def shutdown(self): | |||
| self.checkpoint_saver.join() | |||
|
|
|||
| self.dht.shutdown() | |||
| self.dht.join() | |||
There was a problem hiding this comment.
hivemind.DHT already calls .join() in shutdown().
justheuristic
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hivemind.Server, use the graceful shutdown forConnectionHandlerhivemind.P2P, if we are the first peer, skip checking if the provided identity is free