Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libp2p handlers when ConnectionHandler, DHT, and DecentralizedAverager are shut down #501

Merged
merged 12 commits into from
Aug 17, 2022
Merged

Remove libp2p handlers when ConnectionHandler, DHT, and DecentralizedAverager are shut down #501

merged 12 commits into from
Aug 17, 2022

Conversation

borzunov
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2022 •
edited
Loading

Codecov Report

Merging #501 (f050665) into master (2826147) will increase coverage by 0.61%.
The diff coverage is 94.18%.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   85.71%   86.32%   +0.61%     
==========================================
  Files          80       81       +1     
  Lines        7814     7871      +57     
==========================================
+ Hits         6698     6795      +97     
+ Misses       1116     1076      -40
Impacted Files Coverage Δ
hivemind/moe/server/connection_handler.py 90.62% <85.18%> (+50.08%) ⬆️
hivemind/p2p/p2p_daemon_bindings/control.py 91.60% <96.15%> (+0.03%) ⬆️
hivemind/averaging/averager.py 88.75% <100.00%> (+0.02%) ⬆️
hivemind/averaging/matchmaking.py 88.95% <100.00%> (-0.34%) ⬇️
hivemind/dht/node.py 91.70% <100.00%> (+0.25%) ⬆️
hivemind/dht/protocol.py 93.15% <100.00%> (+0.09%) ⬆️
hivemind/p2p/__init__.py 100.00% <100.00%> (ø)
hivemind/p2p/p2p_daemon.py 95.33% <100.00%> (+0.99%) ⬆️
hivemind/p2p/p2p_daemon_bindings/__init__.py 100.00% <100.00%> (ø)
hivemind/p2p/p2p_daemon_bindings/p2pclient.py 100.00% <100.00%> (ø)
... and 8 more

@borzunov borzunov marked this pull request as ready for review August 16, 2022 08:26
@borzunov borzunov changed the title Implement handler removal in hivemind.P2P Implement handler removal in hivemind.p2p Aug 16, 2022
@borzunov borzunov force-pushed the removing-handlers branch 3 times, most recently from 8e8b85c to 8aa9039 Compare August 16, 2022 14:36
@borzunov borzunov force-pushed the removing-handlers branch 3 times, most recently from 5cb0254 to 8a925f4 Compare August 17, 2022 12:04
@borzunov borzunov changed the title Implement handler removal in hivemind.p2p Remove libp2p handlers while shutting down ConnectionHandler, DHT, Averager Aug 17, 2022
@borzunov borzunov changed the title Remove libp2p handlers while shutting down ConnectionHandler, DHT, Averager Remove libp2p handlers while shutting down ConnectionHandler, DHT, averager Aug 17, 2022
@borzunov borzunov changed the title Remove libp2p handlers while shutting down ConnectionHandler, DHT, averager Remove libp2p handlers when ConnectionHandler, DHT, and DecentralizedAverager are shut down Aug 17, 2022
@borzunov borzunov merged commit 3267fc7 into master Aug 17, 2022
@borzunov borzunov deleted the removing-handlers branch August 17, 2022 14:25
mryab pushed a commit that referenced this pull request Sep 13, 2022
@borzunov @mryab
Remove libp2p handlers when ConnectionHandler, DHT, and Decentralized…
c2a53d0 
…Averager are shut down (#501)

(cherry picked from commit 3267fc7)
@borzunov borzunov mentioned this pull request Oct 11, 2022
Merged
borzunov added a commit that referenced this pull request Oct 11, 2022
@borzunov
Follow up #501 and #511 with minor fixes (#513)
13cdd13 
- In `hivemind.Server`, use the graceful shutdown for `ConnectionHandler`
- In `hivemind.P2P`, if we are the first peer, skip checking if the provided identity is free
mryab pushed a commit that referenced this pull request Oct 19, 2022
@borzunov @mryab
Follow up #501 and #511 with minor fixes (#513)
14de6c5 
- In `hivemind.Server`, use the graceful shutdown for `ConnectionHandler`
- In `hivemind.P2P`, if we are the first peer, skip checking if the provided identity is free

(cherry picked from commit 13cdd13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreenFatGuy GreenFatGuy GreenFatGuy approved these changes

@justheuristic justheuristic Awaiting requested review from justheuristic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borzunov @justheuristic @GreenFatGuy