-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Allow Ethwallets to be created for all cointypes 2. Allow evm transaction signing.
Add/evm 118 wallet
update ethWallet
Total Coverage: Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR...
Changes
API Updates
New Features (required)
This section should include details regarding new features added to the library.
This should include both open and private APIs. If including both, create two
sub headers underneath this one to label updates accordingly.
Deprecations (required)
All deprecations should be listed here in order to ensure the reviewer understands
which sections of the codebase will affect contributors and users of the library.
Enhancements (optional)
The enhancements section should include code updates that were included with this
pull request. This sections should detail refactoring that might have affected
other parts of the library.
Checklist
References
(optional)
Include important links regarding the implementation of this PR.
This usually includes and RFC or an aggregation of issues and/or individual conversations
that helped put this solution together. This helps ensure there is a good aggregation
of resources regarding the implementation.
Fixes #85, Fixes #22, Fixes username/repo#123
Connects #123