Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/evm 118 wallet #20

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Add/evm 118 wallet #20

merged 7 commits into from
Feb 19, 2024

Conversation

baryon2
Copy link
Collaborator

@baryon2 baryon2 commented Feb 19, 2024

  1. Allow Ethwallets to be created for all cointypes
  2. Allow evm transaction signing.

@baryon2
Update keychain
3492a54 
1. Allow Ethwallets to be created for all cointypes
2. Allow evm transaction signing.
@baryon2
Update package version
b10dda5
@asanjeevrao
Copy link

Total Coverage: 0 %

Coverage report
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 65.75 44.24 53.92 67.01
src 100 100 0 100
index.ts 100 100 0 100
src/crypto/bip32 72.22 100 50 72.22
hd-wallet.ts 66.66 100 50 66.66 6-10,22
hdwallet-token.ts 83.33 100 50 83.33 24
src/crypto/bip39 83.33 100 62.5 83.33
bip39-token.ts 100 100 100 100
bip39.ts 75 100 50 75 5,8,11
src/crypto/ecc 85.71 20 60 84.61
secp256k1.ts 85.71 20 60 84.61 13,28
src/crypto/hashes 77.77 100 0 71.42
hashes.ts 77.77 100 0 71.42 10,14
src/encryption-utils 100 75 100 100
encryption-utils.ts 100 75 100 100 12-33
src/key 52.47 19.64 53.48 54.25
eth-wallet.ts 42.16 25 36.84 45.45 38,87-158
wallet-utils.ts 93.54 69.23 100 93.33 35,38
wallet.ts 47.72 0 57.89 48.14 32-71,132-168
src/keychain 67.34 59.15 54.54 69.5
keychain.ts 67.34 59.15 54.54 69.5 35,68,76,131,162-198,213-243,303
src/storage 100 100 100 100
storage-layer.ts 100 100 100 100
src/types 100 100 100 100
keychain.ts 100 100 100 100
src/utils 62.96 42.85 44.44 62.74
correct-mnemonic.ts 66.66 100 0 100
encode-signature.ts 88.88 80 100 88.88 6
encoding.ts 88.88 0 100 87.5 3
get-hdpath.ts 100 50 100 100 1
init-crypto.ts 66.66 100 0 66.66 12-16
serialize-signdoc.ts 25 0 0 25 5-18,22-23,27
tests 100 100 100 100
mockdata.ts 100 100 100 100

@baryon2 baryon2 changed the base branch from main to staging February 19, 2024 19:13
@asanjeevrao
Copy link

Total Coverage: 0 %

Coverage report
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 65.95 44.84 53.92 67.21
src 100 100 0 100
index.ts 100 100 0 100
src/crypto/bip32 72.22 100 50 72.22
hd-wallet.ts 66.66 100 50 66.66 6-10,22
hdwallet-token.ts 83.33 100 50 83.33 24
src/crypto/bip39 83.33 100 62.5 83.33
bip39-token.ts 100 100 100 100
bip39.ts 75 100 50 75 5,8,11
src/crypto/ecc 85.71 20 60 84.61
secp256k1.ts 85.71 20 60 84.61 13,28
src/crypto/hashes 77.77 100 0 71.42
hashes.ts 77.77 100 0 71.42 10,14
src/encryption-utils 100 75 100 100
encryption-utils.ts 100 75 100 100 12-33
src/key 52.97 21.42 53.48 54.78
eth-wallet.ts 42.16 25 36.84 45.45 38,87-158
wallet-utils.ts 96.77 76.92 100 96.66 35
wallet.ts 47.72 0 57.89 48.14 32-71,132-168
src/keychain 67.34 59.15 54.54 69.5
keychain.ts 67.34 59.15 54.54 69.5 35,68,76,131,162-198,213-243,303
src/storage 100 100 100 100
storage-layer.ts 100 100 100 100
src/types 100 100 100 100
keychain.ts 100 100 100 100
src/utils 62.96 42.85 44.44 62.74
correct-mnemonic.ts 66.66 100 0 100
encode-signature.ts 88.88 80 100 88.88 6
encoding.ts 88.88 0 100 87.5 3
get-hdpath.ts 100 50 100 100 1
init-crypto.ts 66.66 100 0 66.66 12-16
serialize-signdoc.ts 25 0 0 25 5-18,22-23,27
tests 100 100 100 100
mockdata.ts 100 100 100 100

1 similar comment
@asanjeevrao
Copy link

Total Coverage: 0 %

Coverage report
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 65.95 44.84 53.92 67.21
src 100 100 0 100
index.ts 100 100 0 100
src/crypto/bip32 72.22 100 50 72.22
hd-wallet.ts 66.66 100 50 66.66 6-10,22
hdwallet-token.ts 83.33 100 50 83.33 24
src/crypto/bip39 83.33 100 62.5 83.33
bip39-token.ts 100 100 100 100
bip39.ts 75 100 50 75 5,8,11
src/crypto/ecc 85.71 20 60 84.61
secp256k1.ts 85.71 20 60 84.61 13,28
src/crypto/hashes 77.77 100 0 71.42
hashes.ts 77.77 100 0 71.42 10,14
src/encryption-utils 100 75 100 100
encryption-utils.ts 100 75 100 100 12-33
src/key 52.97 21.42 53.48 54.78
eth-wallet.ts 42.16 25 36.84 45.45 38,87-158
wallet-utils.ts 96.77 76.92 100 96.66 35
wallet.ts 47.72 0 57.89 48.14 32-71,132-168
src/keychain 67.34 59.15 54.54 69.5
keychain.ts 67.34 59.15 54.54 69.5 35,68,76,131,162-198,213-243,303
src/storage 100 100 100 100
storage-layer.ts 100 100 100 100
src/types 100 100 100 100
keychain.ts 100 100 100 100
src/utils 62.96 42.85 44.44 62.74
correct-mnemonic.ts 66.66 100 0 100
encode-signature.ts 88.88 80 100 88.88 6
encoding.ts 88.88 0 100 87.5 3
get-hdpath.ts 100 50 100 100 1
init-crypto.ts 66.66 100 0 66.66 12-16
serialize-signdoc.ts 25 0 0 25 5-18,22-23,27
tests 100 100 100 100
mockdata.ts 100 100 100 100

@asanjeevrao
Copy link

Total Coverage: 0 %

Coverage report
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 65.95 44.84 53.92 67.21
src 100 100 0 100
index.ts 100 100 0 100
src/crypto/bip32 72.22 100 50 72.22
hd-wallet.ts 66.66 100 50 66.66 6-10,22
hdwallet-token.ts 83.33 100 50 83.33 24
src/crypto/bip39 83.33 100 62.5 83.33
bip39-token.ts 100 100 100 100
bip39.ts 75 100 50 75 5,8,11
src/crypto/ecc 85.71 20 60 84.61
secp256k1.ts 85.71 20 60 84.61 13,28
src/crypto/hashes 77.77 100 0 71.42
hashes.ts 77.77 100 0 71.42 10,14
src/encryption-utils 100 75 100 100
encryption-utils.ts 100 75 100 100 12-33
src/key 52.97 21.42 53.48 54.78
eth-wallet.ts 42.16 25 36.84 45.45 38,87-158
wallet-utils.ts 96.77 76.92 100 96.66 35
wallet.ts 47.72 0 57.89 48.14 32-71,132-168
src/keychain 67.34 59.15 54.54 69.5
keychain.ts 67.34 59.15 54.54 69.5 35,68,76,131,162-198,213-243,303
src/storage 100 100 100 100
storage-layer.ts 100 100 100 100
src/types 100 100 100 100
keychain.ts 100 100 100 100
src/utils 62.96 42.85 44.44 62.74
correct-mnemonic.ts 66.66 100 0 100
encode-signature.ts 88.88 80 100 88.88 6
encoding.ts 88.88 0 100 87.5 3
get-hdpath.ts 100 50 100 100 1
init-crypto.ts 66.66 100 0 66.66 12-16
serialize-signdoc.ts 25 0 0 25 5-18,22-23,27
tests 100 100 100 100
mockdata.ts 100 100 100 100

@baryon2 baryon2 merged commit 40ea6ad into staging Feb 19, 2024
1 of 2 checks passed
@baryon2 baryon2 deleted the add/evm-118-wallet branch February 19, 2024 19:24
@asanjeevrao
Copy link

Total Coverage: 0 %

Coverage report
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 65.95 44.84 53.92 67.21
src 100 100 0 100
index.ts 100 100 0 100
src/crypto/bip32 72.22 100 50 72.22
hd-wallet.ts 66.66 100 50 66.66 6-10,22
hdwallet-token.ts 83.33 100 50 83.33 24
src/crypto/bip39 83.33 100 62.5 83.33
bip39-token.ts 100 100 100 100
bip39.ts 75 100 50 75 5,8,11
src/crypto/ecc 85.71 20 60 84.61
secp256k1.ts 85.71 20 60 84.61 13,28
src/crypto/hashes 77.77 100 0 71.42
hashes.ts 77.77 100 0 71.42 10,14
src/encryption-utils 100 75 100 100
encryption-utils.ts 100 75 100 100 12-33
src/key 52.97 21.42 53.48 54.78
eth-wallet.ts 42.16 25 36.84 45.45 38,87-158
wallet-utils.ts 96.77 76.92 100 96.66 35
wallet.ts 47.72 0 57.89 48.14 32-71,132-168
src/keychain 67.34 59.15 54.54 69.5
keychain.ts 67.34 59.15 54.54 69.5 35,68,76,131,162-198,213-243,303
src/storage 100 100 100 100
storage-layer.ts 100 100 100 100
src/types 100 100 100 100
keychain.ts 100 100 100 100
src/utils 62.96 42.85 44.44 62.74
correct-mnemonic.ts 66.66 100 0 100
encode-signature.ts 88.88 80 100 88.88 6
encoding.ts 88.88 0 100 87.5 3
get-hdpath.ts 100 50 100 100 1
init-crypto.ts 66.66 100 0 66.66 12-16
serialize-signdoc.ts 25 0 0 25 5-18,22-23,27
tests 100 100 100 100
mockdata.ts 100 100 100 100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baryon2 @asanjeevrao