Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move BitVec.udiv/umod/sdiv/smod after add/sub/mul/lt #5623

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

tobiasgrosser
Copy link
Contributor

@tobiasgrosser tobiasgrosser commented Oct 6, 2024

Divison proofs are more likely to depend on add/sub/mul proofs than the other way around. This cleans up #5609, which added division proofs that rely on negation to already be defined.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 6, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 6, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0178f2b70df112a916efaaf8acede9ccea12b950 --onto a4fda010f3d44c02393d5afd5cf05509989daf63. (2024-10-06 07:39:12)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9dac514c2fc80d3f60076314ad30a993a7b2c22f --onto a4fda010f3d44c02393d5afd5cf05509989daf63. (2024-10-07 13:20:08)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 5d6553029cb589669f75b8eb68f0e7d1bd8147ff --onto 1d8555fe0bdd02c82664446309b2e167ac89c9e9. (2024-10-13 18:01:14)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 47e0430b07cdd2569046e531fb44eba5f6ffc3d0 --onto 1d8555fe0bdd02c82664446309b2e167ac89c9e9. (2024-10-13 20:06:45)

@bollu
Copy link
Contributor

bollu commented Oct 6, 2024

LGTM, and I ran a diff, and the only change was to make a terminal simp into a simp only:

bollu@paracompact-2 ~/temp [1]> diff a b
87c87
<   <;> simp [h'', h''']
---
>   <;> simp only [h'', h''', ↓reduceIte, toNat_ofNat, Nat.zero_mod, toNat_umod]

@tobiasgrosser
Copy link
Contributor Author

LGTM, and I ran a diff, and the only change was to make a terminal simp into a simp only:

bollu@paracompact-2 ~/temp [1]> diff a b
87c87
<   <;> simp [h'', h''']
---
>   <;> simp only [h'', h''', ↓reduceIte, toNat_ofNat, Nat.zero_mod, toNat_umod]

This is intentional.

Copy link
Contributor

@bollu bollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it was intentional, LGTM

@tobiasgrosser tobiasgrosser force-pushed the move_sdivmod branch 3 times, most recently from 9ce799c to de56269 Compare October 13, 2024 17:41
@hargoniX hargoniX enabled auto-merge October 13, 2024 17:45
@hargoniX hargoniX added this pull request to the merge queue Oct 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 13, 2024
Divison proofs are more likely to depend on add/sub/mul proofs than the other
way around. This cleans up leanprover#5609, which added division proofs that rely on
negation to already be defined.
@hargoniX hargoniX added this pull request to the merge queue Oct 13, 2024
Merged via the queue into leanprover:master with commit 7fd2aa0 Oct 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants