-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move BitVec.udiv/umod/sdiv/smod after add/sub/mul/lt #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Oct 6, 2024
Mathlib CI status (docs):
|
LGTM, and I ran a bollu@paracompact-2 ~/temp [1]> diff a b
87c87
< <;> simp [h'', h''']
---
> <;> simp only [h'', h''', ↓reduceIte, toNat_ofNat, Nat.zero_mod, toNat_umod] |
This is intentional. |
bollu
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it was intentional, LGTM
tobiasgrosser
force-pushed
the
move_sdivmod
branch
3 times, most recently
from
October 13, 2024 17:41
9ce799c
to
de56269
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 13, 2024
tobiasgrosser
force-pushed
the
move_sdivmod
branch
from
October 13, 2024 19:51
de56269
to
6cca3c9
Compare
Divison proofs are more likely to depend on add/sub/mul proofs than the other way around. This cleans up leanprover#5609, which added division proofs that rely on negation to already be defined.
tobiasgrosser
force-pushed
the
move_sdivmod
branch
from
October 13, 2024 19:51
6cca3c9
to
f4c3144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divison proofs are more likely to depend on add/sub/mul proofs than the other way around. This cleans up #5609, which added division proofs that rely on negation to already be defined.