Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default pp if pp expr/syntax/level without context #4433

Merged
merged 2 commits into from
Jun 14, 2024
Merged

feat: default pp if pp expr/syntax/level without context #4433

merged 2 commits into from
Jun 14, 2024

Conversation

llllvvuu
Copy link
Contributor

@llllvvuu llllvvuu commented Jun 12, 2024 •
edited
Loading

This restores the behavior prior to 9f6bbfa for MessageData.ofSyntax MessageData.ofExpr, and MessageData.ofLevel while staying within the new .ofLazy paradigm.

Also adds some documentation to help developers understand the missing context issue.

Closes #4432

@llllvvuu
Copy link
Contributor Author

llllvvuu commented Jun 12, 2024 •
edited
Loading

Probably a judgment call here; I think it's also fine to require a context. In which case, maybe the right move is to beef up the error messages accordingly.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 12, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 12, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4433
b301bd0
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 12, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4433
b3c1842
@nomeata
Copy link
Collaborator

nomeata commented Jun 12, 2024

More discussion at https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/MessageData.20without.20context/near/444163996

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 12, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 12, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4433
fd0f828
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4433
30611f0
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4433
6105597
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4433
23da0fd
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases and removed builds-mathlib CI has verified that Mathlib builds against this PR labels Jun 13, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4433
98555c2
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4433
090c6cd
nomeata
nomeata reviewed Jun 14, 2024
View reviewed changes
src/Lean/Message.lean Outdated Show resolved Hide resolved
@nomeata nomeata enabled auto-merge June 14, 2024 08:14
@nomeata nomeata added this pull request to the merge queue Jun 14, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 14, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4433
06ce90a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 14, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4433
56b7fde
Merged via the queue into leanprover:master with commit 5d24035 Jun 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata nomeata left review comments

Assignees

@nomeata nomeata

Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

m!"{expr}" doesn't work as of 4.9.0-rc1
3 participants
@llllvvuu @nomeata @leanprover-community-mathlib4-bot