Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: use Batteries test driver directly in the lake file #15897

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions lakefile.lean
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ package mathlib where
leanOptions := mathlibLeanOptions
-- Mathlib also enforces these linter options, which are not active by default.
moreServerOptions := mathlibOnlyLinters
-- Use Batteries' test driver for `lake test`
testDriver := "batteries/test"
-- These are additional settings which do not affect the lake hash,
-- so they can be enabled in CI and disabled locally or vice versa.
-- Warning: Do not put any options here that actually change the olean files,
Expand Down Expand Up @@ -111,18 +113,6 @@ lean_exe pole where
-- Executables which import `Lake` must set `-lLake`.
weakLinkArgs := #["-lLake"]

/--
`lake exe test` is a thin wrapper around `lake exe batteries/test`, until
https://github.com/leanprover/lean4/issues/4121 is resolved.

You can also use it as e.g. `lake exe test conv eval_elab` to only run the named tests.
-/
@[test_driver]
lean_exe test where
-- We could add the above `leanOptions` and `moreServerOptions`: currently, these do not take
-- effect as `test` is a `lean_exe`. With a `lean_lib`, it would work...
srcDir := "scripts"

/-!
## Other configuration
-/
Expand Down
21 changes: 0 additions & 21 deletions scripts/test.lean

This file was deleted.

Loading