Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: use Batteries test driver directly in the lake file #15897

Closed
wants to merge 2 commits into from

Conversation

mattrobball
Copy link
Collaborator

With leanprover/lean4#4261, we can specify a test driver from a dependency. We do this with Batteries test driver. Previously, the test driver from Batteries was called via scripts/test.lean which is now removed.


Open in Gitpod

@mattrobball mattrobball changed the title chore: use Batteries test driver directly in lake test chore: use Batteries test driver directly in the lake file Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

PR summary b4abd0ebc7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- main

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@mattrobball
Copy link
Collaborator Author

mattrobball commented Aug 16, 2024

@kim-em I was looking at lake test for my class and noticed this todo. Local testing seems good but you would know better. Let me know if anything is amiss.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 19, 2024
@grunweg grunweg added the CI Modifies the continuous integration / deployment setup label Aug 20, 2024
@urkud urkud requested review from kim-em and adomani September 2, 2024 17:05
@adomani
Copy link
Collaborator

adomani commented Sep 3, 2024

I don't really know how to review this, since I do not know the implications of the changes! However, I can see that CI was successful and that the tests have been run, so this looks good to me! 😄

@bryangingechen
Copy link
Contributor

@semorrison Could you take a look at this when you have a spare moment?

@kim-em
Copy link
Contributor

kim-em commented Oct 25, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 25, 2024
With leanprover/lean4#4261, we can specify a test driver from a dependency. We do this with `Batteries` test driver. Previously, the test driver from `Batteries` was called via `scripts/test.lean` which is now removed.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: use Batteries test driver directly in the lake file [Merged by Bors] - chore: use Batteries test driver directly in the lake file Oct 25, 2024
@mathlib-bors mathlib-bors bot closed this Oct 25, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/test_driver branch October 25, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Modifies the continuous integration / deployment setup ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants