Add AddressSanitizer support to fibers. #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanEngelen
force-pushed
the
asan_fiber
branch
6 times, most recently
from
d1b2321
to
7c5e5b1
Compare
|
Linux functionality depends on |
JohanEngelen
force-pushed
the
asan_fiber
branch
2 times, most recently
from
63c0295
to
dcb9e4f
Compare
|
Manually tested on macOS and Ubuntu now. I'm satisfied with it now. Depends on #2984 |
JohanEngelen
changed the title
JohanEngelen
force-pushed
the
asan_fiber
branch
from
dcb9e4f
to
4bd8bba
Compare
JohanEngelen
force-pushed
the
asan_fiber
branch
from
4bd8bba
to
16a82c3
Compare
JohanEngelen
force-pushed
the
asan_fiber
branch
from
16a82c3
to
a9f0cc6
Compare
kinke
reviewed
Feb 12, 2019
| @@ -27,6 +27,7 @@ config.gnu_make_bin = "@GNU_MAKE_BIN@" | |||
| config.ldc_host_arch = "@LDC_HOST_ARCH@" | |||
| config.ldc_with_lld = "@LDC_WITH_LLD@" == "ON" | |||
| config.spirv_enabled = @LLVM_SPIRV_FOUND@ +0 # LLVM_SPIRV_FOUND is blank if not set | |||
| config.rt_supports_sanitizers = "@RT_SUPPORT_SANITIZERS@" == "ON" | |||
There was a problem hiding this comment.
I'm not sure, but a cached RT_SUPPORT_SANITIZERS CMake variable might be 1 instead of ON. I think that's why I added
Lines 483 to 488 in 4b101ba
There was a problem hiding this comment.
Going to merge anyway in order to move forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.