Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASan: upon fiber switching, need to tell ASan #2470

Closed
JohanEngelen opened this issue Dec 27, 2017 · 3 comments
Closed

ASan: upon fiber switching, need to tell ASan #2470

JohanEngelen opened this issue Dec 27, 2017 · 3 comments
Assignees
Labels
B-new-feature llvm Related to LLVM

Comments

@JohanEngelen
Copy link
Member

We need to call __sanitizer_start_switch_fiber and __sanitizer_finish_switch_fiber. Reading ASan's code, I think it's only needed when using FakeStack (stack-use-after-scope), but I'm not 100% sure.

See e.g. the calls in this code: https://github.com/facebook/folly/blob/master/folly/fibers/FiberManager.cpp

@JohanEngelen
Copy link
Member Author

Reading ASan's code, I think it's only needed when using FakeStack (stack-use-after-scope), but I'm not 100% sure.

Nope, also needs to be done without fake stack such that ASan correctly reports about pointers lying inside a certain stack frame.

I've made some nice progress on this front. Main open question is how to deal with presence/absence of linked-in ASan runtime library.

@JohanEngelen JohanEngelen self-assigned this Jan 20, 2019
@JohanEngelen
Copy link
Member Author

#2975

@JohanEngelen
Copy link
Member Author

Implemented by #2975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-new-feature llvm Related to LLVM
Projects
None yet
Development

No branches or pull requests

1 participant