Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the unsubscribe button and added a type to the category #1426

Conversation

shamoons
Copy link

@shamoons shamoons commented May 2, 2018

This resolves #1396

Needed to clean up some type declaration as well to get the linting to pass

@lbry-bot
Copy link

lbry-bot commented May 2, 2018

Warnings
⚠️

📄 Changelog Entry Missing - Please add a changelog entry for your changes.

Generated by 🚫 dangerJS

@neb-b
Copy link

neb-b commented May 2, 2018

Hey @shamoons. I recently opened #1424 that changes the subscriptions page. It removes the category list view so these changes won't be needed anymore. I should have closed that issue after opening my PR, I'm sorry about that. I'm going to close this one.

I just checked and the other good first issue tags are all good to be worked on. Possibly #1393 would be a good one? Or any of the others. If you have any questions about what to work on you can message me on discord!

@neb-b neb-b closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "unsubscribe" button in the subscriptions overview
4 participants