Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel information on mouse over #1393

Closed
tzarebczan opened this issue Apr 26, 2018 · 11 comments
Closed

Add channel information on mouse over #1393

tzarebczan opened this issue Apr 26, 2018 · 11 comments
Labels
area: ux area: viewer hacktoberfest Welcome to Hacktoberfest help wanted level: 3 Significant knowledge of the existing code is recommended Tom's Wishlist type: improvement Existing (or partially existing) functionality needs to be changed type: new feature New functionality that does not exist yet

Comments

@tzarebczan
Copy link
Contributor

The Issue

Per a suggestion from a reddit user, it would be a nice feature to have channel stats when mousing over anywhere in the app. Right now we can include how many videos are in the channel, but in the future we can include things like: # of subscribers, channel description, etc.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@tzarebczan tzarebczan added type: improvement Existing (or partially existing) functionality needs to be changed area: ux help wanted good first issue level: 1 No knowledge of the existing code required type: new feature New functionality that does not exist yet area: viewer labels Apr 26, 2018
@shamoons
Copy link

shamoons commented May 2, 2018

What is considered a channel?

@tzarebczan
Copy link
Contributor Author

tzarebczan commented May 2, 2018

@shamoons anything with an @ infront of it. You'll notice them on the discover page, show page and in other parts of the app. If there is no channel, it will show anonymous.

Example: https://www.screencast.com/t/Pd895bHNTu

@neb-b
Copy link

neb-b commented May 2, 2018

Not sure if this should be a custom component or if it can be done with just a css class. But ideally this should be generic enough that we can use this in other parts of the app too. One example is on the icons in that picture ^. It should say "Rewards" if you hover over the red rocket. That's out of the scope for this issue though.

@neb-b
Copy link

neb-b commented May 2, 2018

Possibly we could wrap anything we want to have a hover message in a custom comopent

<WithHover onHover="This is the hover message"> // that could also take a react component as props
    <UriIndicator uri={uri} />
</WithHover>

@alyssaoc alyssaoc added the icebox Long-term storage label Aug 10, 2018
@alyssaoc alyssaoc added level: 3 Significant knowledge of the existing code is recommended help wanted hacktoberfest Welcome to Hacktoberfest and removed help wanted level: 1 No knowledge of the existing code required good first issue icebox Long-term storage labels Oct 12, 2018
@tzarebczan
Copy link
Contributor Author

We can now entertain this feature given we have channel metadata :)

@btzr-io
Copy link
Collaborator

btzr-io commented May 30, 2019

Is anyone working on this ?

@tzarebczan
Copy link
Contributor Author

@btzr-io , nope, she's all yours! I'd say it would be a condensed version of what's on the channel page - potentially total number of claims, title, canonical url (coming soon), description (truncated?), number of subs (coming soon), email, thumbnail, tip (not on channel page yet) and sub buttons.

@btzr-io
Copy link
Collaborator

btzr-io commented Jun 3, 2019

I made some initial progress on this, just added some basic information (thumbnail, description and channel name):

@btzr-io
Copy link
Collaborator

btzr-io commented Jun 3, 2019

I don't think email is that important ?

@kauffj
Copy link
Member

kauffj commented Jun 3, 2019

@btzr-io that looks awesome! I agree on not adding email or probably anything else.

@btzr-io btzr-io removed their assignment Jun 25, 2019
@tzarebczan
Copy link
Contributor Author

This was implemented in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ux area: viewer hacktoberfest Welcome to Hacktoberfest help wanted level: 3 Significant knowledge of the existing code is recommended Tom's Wishlist type: improvement Existing (or partially existing) functionality needs to be changed type: new feature New functionality that does not exist yet
Projects
None yet
Development

No branches or pull requests

6 participants