-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout modal needs to be smarter #328
Comments
We definitely need some work on this as the current message is not informative. For instance, a failed download shows the sdhash Users are not familiar with the SDhash, so the URL should be shown |
@tzarebczan url is also weird, what about -> url: |
Yep, the title seems to make much more sense here, thanks for making that evident. |
@seanyesmunt / @liamcardenas - since lbryio/lbry-sdk#883 (comment) now shows the URL, we should show that instead of the sd-hash. Ultimately I think we would want to show the title. Also, maybe we can simplify the popup - doesn't need to say "this error has been reported" but instead explain that it could not download the file at this time, please try again later. If they consistently see this error across multiple files, they should visit https://lbry.io/faq/unable-to-stream (I can beef this up to be more generic). Reasons for download failures could be DHT issues on our side, old content that was never properly seeded, or network issues on the users' side. When @6ea86b96 originally opened this ticket, I'm not sure if it was showing the incorrect file, maybe just some confusion there. But if you start download A, then go to claim B and while there, download A times out, it still shows the data for download A failure (and not download B as claimed in this ticket). |
The Issue
If a load/download fails, and you are on a different file page, an error modal appears showing the name of the current file, not the one downloading
Steps to reproduce
Expected behaviour
An error modal should appear with the correct file details.
Actual behaviour
An error modal appears with the current file details
The text was updated successfully, but these errors were encountered: