Add support for publishing new custom votings #115
Conversation
models/custom-vote.js
Outdated
|
|
||
| constructor({ uri, position, content, context }) { | ||
| this.type = 'customVote'; | ||
| this.isCustomVote = true; |
There was a problem hiding this comment.
You're saving this information in 3 separate locations:
isCustomVote on custom votes, isStandardVote on standard votes, and type
why not just use type?
There was a problem hiding this comment.
Ahhhh yes, that's something I wanted to ask, I didn't find a way of doing the (eq this.type "customVote) or something similar in handlebars, so I created these properties. Is there a way of doing that?
And I thought I didn't wanted just to have isCustomVote and isStandardVote so I kept the type property
There was a problem hiding this comment.
hmm I'll have a look, but at a minimum you could calculate the boolean at the point of passing the context to the template instead of storing it here
There was a problem hiding this comment.
you can define your own helpers like this: https://handlebarsjs.com/guide/expressions.html#helpers
There was a problem hiding this comment.
Done thanks :)
Made it possible to publish the new custom votes generated in GN
Related to this lblod/frontend-gelinkt-notuleren#732