Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/manual voting #732

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Feat/manual voting #732

wants to merge 16 commits into from

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Oct 15, 2024

Overview

Added a way to add a custom voting to the behandeling that will be just a document

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4991
lblod/app-gelinkt-notuleren#198

Setup

You should use the lblod/app-gelinkt-notuleren#198 as backend

How to test/reproduce

Go to the meeting form, and notice that you should be able to add custom votings that just let you write some text in the a document

Challenges/uncertainties

We should maybe add some extra rdfa in the document, I will have a look when I finish the prepublisher and see how the final document looks like
As I said the prepublisher is not finished, so that's something I have to finish before merging this PR

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@lagartoverde lagartoverde self-assigned this Oct 15, 2024
@lagartoverde lagartoverde added the enhancement New feature or request label Oct 15, 2024
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug:

  • add custom voting to an ap which doesn't have participants configured
  • voting doesn't get added, but participant button is now greyed out

bug:

  • you can now add a normal voting even if there are no participants, which was previously not allowed (and also doesn't work when you try to save the voting)

bug:

image
my browser is in dutch, but "custom voting" is not translated
bug:
image
pill not aligned nicely
bug:
image
in general could use a bit of padding or something to make it clear this is an input field

bug:

  • edit title, and directly click on meeting "save" button
  • "saved" pill shows, but title is not changed

bug:
"save" button does nothing, only "save and quit" works

bug:
not sure what's going on here:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants