Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in EnergyPlus reading output variable "Zone Mean Air Temperature" #1681

Closed
mwetter opened this issue Dec 13, 2019 · 4 comments
Closed
Assignees
Labels
spawn Development for Spawn of EnergyPlus

Comments

@mwetter
Copy link
Member

mwetter commented Dec 13, 2019

Support reading output variable "Zone Mean Air Temperature". This need to be supported on the EnergyPlus side. Modelica currently issues an assertion to guard against reading this output. This was added in commit d6669ad

@mwetter mwetter added the spawn Development for Spawn of EnergyPlus label Dec 13, 2019
@kbenne
Copy link
Contributor

kbenne commented Mar 5, 2020

I made a correction to address this here: NREL/Spawn@1c30973

There appears to be a lag of two timesteps though, so I am not ready to close this issue. It is probably the same root issue as this #1679

@kbenne
Copy link
Contributor

kbenne commented Mar 5, 2020

I made a second correction to addressing lagging here NREL/Spawn@a61f2b3

As the commit message describes, the "zone mean air temperature" output variable will still only be updated when time crosses a zone timestep. @mwetter I'm guessing that what you want is for the output variables to be update immediately given the current inputs, is that correct? I can make another commit to definitively make that happen for "zone mean air temperature" but there might be a whack a mole situation as I go down this road as there is not one centralized function or method call to update all report variables.

@mwetter
Copy link
Member Author

mwetter commented Mar 6, 2020

@kbenne : Yes, the output should be updated for the current input variables.

@kbenne
Copy link
Contributor

kbenne commented Mar 13, 2020

Addressed here: NREL/Spawn@e443d63

Please read the commit log for details. We might need to open new issues to address lag in other output variables, but I have addressed many of them.

mwetter added a commit that referenced this issue Apr 2, 2020
@mwetter mwetter mentioned this issue Apr 2, 2020
2 tasks
@mwetter mwetter closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spawn Development for Spawn of EnergyPlus
Projects
None yet
Development

No branches or pull requests

2 participants