EnergyPlus returns for OutputVariable the schedule value before rather than after time advanced

[mwetter]

Simulating Buildings.ThermalZones.EnergyPlus.Validation.OneZoneOneOutputVariable gives the following output:

************** Debug for output OneZoneOneOutputVariable.equEle, time = 83700.00, y = 483.09
************** Debug for output OneZoneOneOutputVariable.equEle, time = 84600.00, y = 483.09
************** Debug for output OneZoneOneOutputVariable.equEle, time = 85500.00, y = 483.09
************** Debug for output OneZoneOneOutputVariable.equEle, time = 86400.00, y = 483.09
Continuing Simulation at 01/01/2017 for ANNUAL
************** Debug for output OneZoneOneOutputVariable.equEle, time = 87300.00, y = 644.13
************** Debug for output OneZoneOneOutputVariable.equEle, time = 88200.00, y = 644.13
************** Debug for output OneZoneOneOutputVariable.equEle, time = 89100.00, y = 644.13

The expected value is

time = 86400.00, y = 644.13

These are values from the EnergyPlus schedule

  Schedule:Compact,
    BLDG_EQUIP_SCH,          !- Name
    Fraction,                !- Schedule Type Limits Name
    Through: 12/31,          !- Field 1
    For: Weekdays,           !- Field 2
    Until: 08:00,0.40,       !- Field 3
    Until: 12:00,0.90,       !- Field 5
    Until: 13:00,0.80,       !- Field 7
    Until: 17:00,0.90,       !- Field 9
    Until: 18:00,0.50,       !- Field 11
    Until: 24:00,0.40,       !- Field 13
    For: Saturday,           !- Field 15
    Until: 06:00,0.30,       !- Field 16
    Until: 08:00,0.4,        !- Field 18
    Until: 12:00,0.5,        !- Field 20
    Until: 17:00,0.35,       !- Field 22
    Until: 24:00,0.30,       !- Field 24
    For: SummerDesignDay,    !- Field 26
    Until: 24:00,1.0,        !- Field 27
    For: WinterDesignDay,    !- Field 29
    Until: 24:00,0.0,        !- Field 30
    For: AllOtherDays,       !- Field 32
    Until: 24:00,0.30;       !- Field 33

EnergyPlus needs to be changed so it outputs the value of the schedule that is active at the time step that starts at time because Modelica already requested an event update in the code

  /* Get next event time, unless FMU is in initialization mode */
  if (bui->mode == initializationMode){
    if (FMU_EP_VERBOSITY >= MEDIUM)
      ModelicaFormatMessage(
        "Returning current time %.0f as tNext due to initializationMode for zone = %s\n",
        bui->time,
        outVar->modelicaNameOutputVariable);
    *tNext = bui->time; /* Return start time for next event time */
  }
  else{
    if (FMU_EP_VERBOSITY >= TIMESTEP)
      ModelicaFormatMessage("Calling do_event_iteration for output = %s\n", outVar->modelicaNameOutputVariable);
    *tNext = do_event_iteration(bui, outVar->modelicaNameOutputVariable);
  }
  /* Get output */
  getVariables(bui, outVar->modelicaNameOutputVariable, outVar->outputs);

[mwetter]

The branch to reproduce it is issue1679_spawnDelayedScheduleValue.

[kbenne]

Partially or fully address here NREL/Spawn@a61f2b3 but need testing.

[kbenne]

Addressed further here NREL/Spawn@e443d63 but please read the commit log.

[mwetter]

This is now corrected for the internal loads.