-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAPS: fix for the build issues by removing sky-test from use in maps #188
Conversation
replaces sky-test why sky_pando the proper texture which fixes the build issues we have been having
The build is still failing since I merged e1m4 which uses textures from #183. If you review and approve that PR, I can merge it and that will solve this. |
I am confused over the coordination here. Is this PR required or is there another PR that is also resolving this same build failure? Please communicate, thanks |
you aren't using sky-test at all are ya? |
the one I linked fixed this issue but that pull req has been stalled by a want for more polish on the sky textures so this pull req is just the fix that removes the sky-test texture from reference in any of the maps sorry that I wasn't clear |
@lavenderdotpet You'll have to merge master back into this branch to get it to pass the checks now. |
i think thats correct? |
Description of Changes
replaces sky-test why sky_pando the proper texture which fixes the build issues we have been having
this fix was a part of this pull request but now has been separated to since more changes were requested on that side that was stalling this fix from being applied
Visual Sample
Checklist