Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WADS, MAPS: sky texture revamp #130

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

lavenderdotpet
Copy link
Owner

@lavenderdotpet lavenderdotpet commented Mar 31, 2024

-- old versions of the pull req --
cleaned up these sky textures and removed an old/unfinished attempt at cleaning them up
sky_orng
sky_pando
sky_pando2

new version starts here ↓

Description of Changes


updated/cleaned up sky textures that i did in substance painter and edited in gimp

also some maps that used sky-test had the file replaced with the propper texture and sky-test was removed due to it breaking github auto build system as seen here #182 (comment)
the old versions of the skys were added to the legacy wad

Visual Sample


sky

side note: also the last one there is just an extra now exists as sky_galx2 the old one is sky_galx

screenshot of maps using sky-test that i changed to the proper texture
image

Checklist


  • I have read the LibreQuake contribution guidelines
  • I have thoroughly tested my changes to the best of my ability
  • I confirm I have not contributed anything that would impact LibreQuake's licensing and usage
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@lavenderdotpet
Copy link
Owner Author

gonna work on this tonight

made in substance designer by me
made in substance designer by me + editing in gimp
@lavenderdotpet lavenderdotpet marked this pull request as ready for review October 12, 2024 16:40
@lavenderdotpet lavenderdotpet changed the title Lav skytexture cleanup WADS, MAPS: sky texture revamp + fix/removal of sky-test Oct 12, 2024
accidentally uploaded the new 1 twice so sky_galx and sky_galx2 where the same file
the first one is now the original one
@lavenderdotpet
Copy link
Owner Author

image

@lavenderdotpet lavenderdotpet marked this pull request as draft October 12, 2024 17:31
@MotoLegacy
Copy link
Collaborator

In the future please follow our guidelines for commit messages

@lavenderdotpet
Copy link
Owner Author

In the future please follow our guidelines for commit messages

forgot that commits are under the same rules as pull reqs
my bad

Copy link
Collaborator

@Nolcoz Nolcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new sky textures look really nice. Its good ye

@lavenderdotpet lavenderdotpet changed the title WADS, MAPS: sky texture revamp + fix/removal of sky-test WADS, MAPS: sky texture revamp Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants