-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare 1.5.0 release #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add goreleaser.yml * Update changelog * fix version number
* Add GH actions for release * Bump travis version * Update readme
* prepare 1.2.2 release (#24) * Fix non-empty plan when creating a team member with a custom role (#63) * Fix handling of missing user target variation in API response (#64) Co-authored-by: Isabelle Miller <[email protected]> * v1.2.2 * Cleanup after v1.2.2 release * [ch85469] first pass at tokens * Update launchdarkly/resource_launchdarkly_access_token.go Co-authored-by: Henry Barrow <[email protected]> * add links to sensitive data callout * expiry and permission fixes * update markdown * use latest openapi client * keys * tidy * fixes * docs update * Fix go.mod and vendoring * Remove henry's fmt.Printf * Clean up go.mod * clean up go.mod even further * address some of review * custom role keys instead of ids * remove unused var * reintroduce removed code * remove references to deleted key * Remove fmt.Println * formatting fixes * fix tests Co-authored-by: Henry Barrow <[email protected]> Co-authored-by: Isabelle Miller <[email protected]> Co-authored-by: tf-release-bot <[email protected]>
* update changelog for 1.4.0 * prepare 1.4.0 release (#37) * Prep for migration release (#75) * add goreleaser.yml * Update changelog * fix version number * Add GH actions for release (#76) * Add GH actions for release * Bump travis version * Update readme * Automatically add changelog entry to release (#77) * Update go.mod and automatically set version header (#78) * Add access tokens (#79) * prepare 1.2.2 release (#24) * Fix non-empty plan when creating a team member with a custom role (#63) * Fix handling of missing user target variation in API response (#64) Co-authored-by: Isabelle Miller <[email protected]> * v1.2.2 * Cleanup after v1.2.2 release * [ch85469] first pass at tokens * Update launchdarkly/resource_launchdarkly_access_token.go Co-authored-by: Henry Barrow <[email protected]> * add links to sensitive data callout * expiry and permission fixes * update markdown * use latest openapi client * keys * tidy * fixes * docs update * Fix go.mod and vendoring * Remove henry's fmt.Printf * Clean up go.mod * clean up go.mod even further * address some of review * custom role keys instead of ids * remove unused var * reintroduce removed code * remove references to deleted key * Remove fmt.Println * formatting fixes * fix tests Co-authored-by: Henry Barrow <[email protected]> Co-authored-by: Isabelle Miller <[email protected]> Co-authored-by: tf-release-bot <[email protected]> * update changelog for 1.4.0 Co-authored-by: Henry Barrow <[email protected]> Co-authored-by: Isabelle Miller <[email protected]> Co-authored-by: tf-release-bot <[email protected]> Co-authored-by: Henry Barrow <[email protected]> Co-authored-by: Isabelle Miller <[email protected]> Co-authored-by: tf-release-bot <[email protected]>
…ake changes when creating (#82) * Ensure optional feature flag environment properties really are optional * Update changelog
* add stub schema * add read function that gets project by key * fix syntax issues * add test helper functions * add dataSourceProject to the provider * add test for an existing resource add test for an existing data source * add getProjectByKey method * name should be optional * fix test * add rate limiting to api hit in test to avoid 429 error * add include_in_snippet to project resource * extract projectRead into a helper function * set id for data source but not resource * add comment * remove redundant get function * fix tests * add include_in_snippet to project resource update test
* Add .circleci/config.yml * specify working directory * update run command * comment out run command to see if it will build * uncomment run & clean up' : * fix formatting * change go version to 1.14 * add make vet * fix indentation * scrap travis * don't run this test in parallel, see if it works * that wasn't it * add a 200ms sleep after creating custom roles to see if it fixes the not found error * limit to 3 packages at a time * try running just one package at a time? * try a sleep of 1 second after custom role creation * only clean team members that are pending invite * run only team member tests * run only create test * only run update with custom role * try all the team member tests again with seat limit flag off * run all team member tests separately * add test clean account * remove -p and add custom props * through test acc access token * fix test name typo * add all tests separately * remove sleep * don't run cleaner test * run creates separately * forgot to commit test name change * run all four tests separately
* add stub schema * add read function that gets project by key * fix syntax issues * add test helper functions * add dataSourceProject to the provider * add test for an existing resource add test for an existing data source * add getProjectByKey method * name should be optional * fix test * add rate limiting to api hit in test to avoid 429 error * add include_in_snippet to project resource * extract projectRead into a helper function * set id for data source but not resource * add comment * remove redundant get function * fix tests * add include_in_snippet to project resource update test * extract read into helper funciton * stub data source * add isDataSource param to env read helper * actually add data source to provider * fix schema * add bad env test + scaffolding * make a separate schema for env data source because of differing required/optional fields * add test to check that it can get env * add id check to test * fix travis build * remove unnecessary fields from config * refactor schemas to use overlapping baes * scrap redundant config * Update launchdarkly/environments_helper.go Co-authored-by: Henry Barrow <[email protected]> * Update launchdarkly/environments_helper.go Co-authored-by: Henry Barrow <[email protected]> Co-authored-by: Henry Barrow <[email protected]>
* add stub schema * add read function that gets project by key * fix syntax issues * add test helper functions * add dataSourceProject to the provider * add test for an existing resource add test for an existing data source * add getProjectByKey method * name should be optional * fix test * add rate limiting to api hit in test to avoid 429 error * add include_in_snippet to project resource * extract projectRead into a helper function * set id for data source but not resource * add comment * remove redundant get function * fix tests * add include_in_snippet to project resource update test * extract read into helper funciton * stub data source * add isDataSource param to env read helper * actually add data source to provider * fix schema * add bad env test + scaffolding * make a separate schema for env data source because of differing required/optional fields * add test to check that it can get env * add id check to test * fix travis build * remove unnecessary fields from config * stub data source * extract read from resource into helper & stub data source * extract test helpers into a test_utils file * add ff data source to provider * make variation_type optional * pass bool through read function to differentiate between resource and data source * add no match test * add scaffold helper function * add exists test * refactor schemas to use overlapping baes * refactor to use overlapping base schema b/w resource and data source * scrap redundant config * scrap redundant config * fix merge issue * fix merge again
* add stub schema * add read function that gets project by key * fix syntax issues * add test helper functions * add dataSourceProject to the provider * add test for an existing resource add test for an existing data source * add getProjectByKey method * name should be optional * fix test * add rate limiting to api hit in test to avoid 429 error * add include_in_snippet to project resource * extract projectRead into a helper function * set id for data source but not resource * add comment * remove redundant get function * fix tests * add include_in_snippet to project resource update test * extract read into helper funciton * stub data source * add isDataSource param to env read helper * actually add data source to provider * fix schema * add bad env test + scaffolding * make a separate schema for env data source because of differing required/optional fields * add test to check that it can get env * add id check to test * fix travis build * remove unnecessary fields from config * stub data source * extract read from resource into helper & stub data source * extract test helpers into a test_utils file * add ff data source to provider * make variation_type optional * pass bool through read function to differentiate between resource and data source * add no match test * add scaffold helper function * add exists test * refactor schemas to use overlapping baes * refactor to use overlapping base schema b/w resource and data source * stub data source file * extract schema into helper function * extract read function into helper * basic data source * move flagIdToKeys into feature flag helper * stub test config * scrap redundant config * scrap redundant config * move patchFlagEnvPath() into helper * add test scaffolding function * stub nomatch test * i did a very dumb thing - fix test * fix test again * return flag instead of config * add exists test * change all read functions to generic featureFlagEnvironmentRead * move test helper into data source * clean up test utils * move helper to correct file and update test to patch everything * check all the things * fix assertions * oops found a bug
* add stub schema * add read function that gets project by key * fix syntax issues * add test helper functions * add dataSourceProject to the provider * add test for an existing resource add test for an existing data source * add getProjectByKey method * name should be optional * fix test * add rate limiting to api hit in test to avoid 429 error * add include_in_snippet to project resource * extract projectRead into a helper function * set id for data source but not resource * add comment * remove redundant get function * fix tests * add include_in_snippet to project resource update test * extract read into helper funciton * stub data source * add isDataSource param to env read helper * actually add data source to provider * fix schema * add bad env test + scaffolding * make a separate schema for env data source because of differing required/optional fields * add test to check that it can get env * add id check to test * fix travis build * remove unnecessary fields from config * stub data source * extract read from resource into helper & stub data source * extract test helpers into a test_utils file * add ff data source to provider * make variation_type optional * pass bool through read function to differentiate between resource and data source * add no match test * add scaffold helper function * add exists test * refactor schemas to use overlapping baes * refactor to use overlapping base schema b/w resource and data source * stub data source file * extract schema into helper function * extract read function into helper * basic data source * move flagIdToKeys into feature flag helper * stub test config * scrap redundant config * scrap redundant config * move patchFlagEnvPath() into helper * add test scaffolding function * stub nomatch test * i did a very dumb thing - fix test * fix test again * return flag instead of config * add exists test * add a webhooks helper file * extract out base schema from resource * extract out read function * fix typo & stub data source * change all read functions to generic featureFlagEnvironmentRead * move test helper into data source * clean up test utils * move helper to correct file and update test to patch everything * check all the things * fix assertions * oops found a bug * oops make enabled optional * refactor read * forgot to define func param type * stub tests * add webhook & ff-env data sources to provider * no match test * set id for data source in read * add webhook exists test * change webhook_id to id * add policy to test
* add stub schema * add read function that gets project by key * fix syntax issues * add test helper functions * add dataSourceProject to the provider * add test for an existing resource add test for an existing data source * add getProjectByKey method * name should be optional * fix test * add rate limiting to api hit in test to avoid 429 error * add include_in_snippet to project resource * extract projectRead into a helper function * set id for data source but not resource * add comment * remove redundant get function * fix tests * add include_in_snippet to project resource update test * extract read into helper funciton * stub data source * add isDataSource param to env read helper * actually add data source to provider * fix schema * add bad env test + scaffolding * make a separate schema for env data source because of differing required/optional fields * add test to check that it can get env * add id check to test * fix travis build * remove unnecessary fields from config * stub data source * extract read from resource into helper & stub data source * extract test helpers into a test_utils file * add ff data source to provider * make variation_type optional * pass bool through read function to differentiate between resource and data source * add no match test * add scaffold helper function * add exists test * refactor schemas to use overlapping baes * refactor to use overlapping base schema b/w resource and data source * stub data source file * extract schema into helper function * extract read function into helper * basic data source * move flagIdToKeys into feature flag helper * stub test config * scrap redundant config * scrap redundant config * move patchFlagEnvPath() into helper * add test scaffolding function * stub nomatch test * i did a very dumb thing - fix test * fix test again * return flag instead of config * add exists test * add a webhooks helper file * extract out base schema from resource * extract out read function * fix typo & stub data source * change all read functions to generic featureFlagEnvironmentRead * move test helper into data source * clean up test utils * move helper to correct file and update test to patch everything * check all the things * fix assertions * oops found a bug * oops make enabled optional * refactor read * forgot to define func param type * stub tests * add webhook & ff-env data sources to provider * no match test * set id for data source in read * add webhook exists test * extract out resource schema * extract out hte read function * add data source to provider * check accTest in webhook test * differentiate read for resource & ds * data source * add no match test * set id for data sources in read * add exists test * extract out resource schema * extract out hte read function * fix merge conflict * make project key required on segment resource Co-authored-by: Henry Barrow <[email protected]> * change webhook_id to id * add policy to test * change name from optional to computed Co-authored-by: Henry Barrow <[email protected]> Co-authored-by: Henry Barrow <[email protected]>
…t read efficiency (#93) * Use GetOKExists for off_variation and improve read efficiency
* add stub schema * add read function that gets project by key * fix syntax issues * add test helper functions * add dataSourceProject to the provider * add test for an existing resource add test for an existing data source * add getProjectByKey method * name should be optional * fix test * add rate limiting to api hit in test to avoid 429 error * add include_in_snippet to project resource * extract projectRead into a helper function * set id for data source but not resource * add comment * remove redundant get function * fix tests * add include_in_snippet to project resource update test * extract read into helper funciton * stub data source * add isDataSource param to env read helper * actually add data source to provider * fix schema * add bad env test + scaffolding * make a separate schema for env data source because of differing required/optional fields * add test to check that it can get env * add id check to test * fix travis build * remove unnecessary fields from config * stub data source * extract read from resource into helper & stub data source * extract test helpers into a test_utils file * add ff data source to provider * make variation_type optional * pass bool through read function to differentiate between resource and data source * add no match test * add scaffold helper function * add exists test * refactor schemas to use overlapping baes * refactor to use overlapping base schema b/w resource and data source * stub data source file * extract schema into helper function * extract read function into helper * basic data source * move flagIdToKeys into feature flag helper * stub test config * scrap redundant config * scrap redundant config * move patchFlagEnvPath() into helper * add test scaffolding function * stub nomatch test * i did a very dumb thing - fix test * fix test again * return flag instead of config * add exists test * add a webhooks helper file * extract out base schema from resource * extract out read function * fix typo & stub data source * change all read functions to generic featureFlagEnvironmentRead * move test helper into data source * clean up test utils * move helper to correct file and update test to patch everything * check all the things * fix assertions * oops found a bug * oops make enabled optional * refactor read * forgot to define func param type * stub tests * add webhook & ff-env data sources to provider * no match test * set id for data source in read * add webhook exists test * extract out resource schema * extract out hte read function * add data source to provider * check accTest in webhook test * differentiate read for resource & ds * data source * add no match test * set id for data sources in read * add exists test * extract out resource schema * extract out hte read function * fix merge conflict * make project key required on segment resource Co-authored-by: Henry Barrow <[email protected]> * change webhook_id to id * add policy to test * add new include_in_snippet arg to proj resource doc * add project ds doc * project key should be required in env ds * add env ds doc * update schema fields in ff ds * fix typos * feature flag ds doc * no validation function on computed schema type * fix feature_flag_env data source & tests * add feature_flag_environment data source doc * remove extra dashes for consistency * add webhook ds doc * fix typo * refactor a bit for conciseness * fix error in segment resource doc * add segment doc * differentiate reads between resource and ds for ff-env * change name from optional to computed Co-authored-by: Henry Barrow <[email protected]> * minor fixes * fix hcl example formatting * change resource to data source * update some wording & add ds links to website sidebar * go get new api version & go mod vendor * add client_side_availability ky * add client side availability to flag data source * switch out snippet for client side availability in project data source * convert client side availability struct to appropriate map for data source * update project test * update feature flag read to set csa * update feature flag data source test * change include_in_snippet to client_side_availability in project & ff ds docs * set include_in_snippet for feature flag resource instead of csa * add csa block section to project & ff docs * fix alignment * update changelog * singularize 'block' * update wording * update wording Co-authored-by: Henry Barrow <[email protected]> * change SDKS to SDKs Co-authored-by: Henry Barrow <[email protected]> * change SDKS to SDKs Co-authored-by: Henry Barrow <[email protected]> Co-authored-by: Henry Barrow <[email protected]>
ldhenry
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1.5.0] (September 29, 2020)
FEATURES:
Added a
launchdarkly_project
data source.Added a
launchdarkly_environment
data source.Added a
launchdarkly_feature_flag
data source.Added a
launchdarkly_feature_flag_environment
data source.Added a
launchdarkly_segment
data source.Added a
launchdarkly_webhook
data source.ENHANCEMENTS:
BUG FIXES:
Resolved issues with the
launchdarkly_project
'senvironments
attribute. This attribute is no longer marked as deprecated and should be used when you wish to override the behavior of creatingTest
andProduction
environments during project creation.Fixed a bug where creating a
launchdarkly_feature_flag_environment
with anoff_variation
was not actually setting the off variation.NOTES:
launchdarkly_project
'senvironments
attribute is no longer marked ascomputed
. This means that if you havelaunchdarkly_project
resources without nestedenvironments
that were created before this version, you will see a diff denoting the removal of the computed environments from your state. It is safe to apply this change as no changes be made to your LaunchDarkly resources when applied.