Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules within "launchdarkly_segment" are not applied by default #79

Closed
stephledev opened this issue Jan 20, 2022 · 3 comments
Closed

Rules within "launchdarkly_segment" are not applied by default #79

stephledev opened this issue Jan 20, 2022 · 3 comments

Comments

@stephledev
Copy link

stephledev commented Jan 20, 2022

When creating a segment with the launchdarkly_segment resource any defined rules within will show an extra "then-clause" in the LaunchDarkly app interface:

This option by default is set to include 0% of all users targeted which effectively makes it deactivated. The rules block within the launchdarkly_segment has no option to override this. When creating a new rule through the app interface, this "then-clause" doesn't pop up.

Is this intentional? Is there a possibility to add support to control this?

@ldhenry
Copy link
Collaborator

ldhenry commented Jan 20, 2022

Hey @stephledev,

This does seem pretty counterintuitive. We'll look into applying a fix. In the meantime, you should be able to set the weight to 100000 to get the rule to apply to all users that match the rule.

Thanks,
Henry

@stephledev
Copy link
Author

thanks for your response @ldhenry. tested your workaround and it works 👌 let me know when there is a fix available.

@ldhenry
Copy link
Collaborator

ldhenry commented Jan 21, 2022

Hey @stephledev, we just released a fix for this issue in v2.4.1. Thanks for bringing this to our attention.

@ldhenry ldhenry closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants