-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yarn topological dev build #291
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,9 @@ inputs: | |
workspace_path: | ||
description: 'Path to the package to release.' | ||
required: true | ||
|
||
should_build_docs: | ||
description: 'Whether docs should be built. It will be by default.' | ||
default: true | ||
Comment on lines
+14
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As requested @kinyoklion There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I really wish the CI was running for these PRs so I could be sure. I added a rule that any branch that starts with As is, I will approve this PR, and then we will need to check that the docs steps are running correctly on the other. My main apprehension is about the types. I think that it will always be a 'string' in this case and 'true' is what we want. But the builds will tell us for sure. |
||
runs: | ||
using: composite | ||
steps: | ||
|
@@ -40,4 +42,5 @@ runs: | |
|
||
- name: Build Docs | ||
shell: bash | ||
if: ${{inputs.should_build_docs == 'true'}} | ||
run: yarn build:doc -- ${{ inputs.workspace_path }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this was incorrectly set as cloudflare @louis-launchdarkly . I have fixed this now.