Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: yarn topological dev build #291

Merged
merged 3 commits into from
Oct 2, 2023
Merged

fix: yarn topological dev build #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18498d2
fix: add build-types command and run prior to building mocks.
yusinto Oct 2, 2023
b4ce1a6
fix: incorrect ga workflow name. don't run typedoc for mocks.
yusinto Oct 2, 2023
aa596fb
fix: parameterize build-docs step
yusinto Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/mocks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: sdk/cloudflare
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was incorrectly set as cloudflare @louis-launchdarkly . I have fixed this now.

name: shared/mocks

on:
push:
Expand All @@ -22,3 +22,4 @@ jobs:
with:
workspace_name: '@launchdarkly/private-js-mocks'
workspace_path: packages/shared/mocks
should_build_docs: false
5 changes: 4 additions & 1 deletion actions/ci/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ inputs:
workspace_path:
description: 'Path to the package to release.'
required: true

should_build_docs:
description: 'Whether docs should be built. It will be by default.'
default: true
Comment on lines +14 to +16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested @kinyoklion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish the CI was running for these PRs so I could be sure.

I added a rule that any branch that starts with feat/ will run all checks when PR'd against. When we have cumulative ones like this, we will probably want to leverage that.

As is, I will approve this PR, and then we will need to check that the docs steps are running correctly on the other.

My main apprehension is about the types. I think that it will always be a 'string' in this case and 'true' is what we want. But the builds will tell us for sure.

runs:
using: composite
steps:
Expand Down Expand Up @@ -40,4 +42,5 @@ runs:

- name: Build Docs
shell: bash
if: ${{inputs.should_build_docs == 'true'}}
run: yarn build:doc -- ${{ inputs.workspace_path }}
1 change: 1 addition & 0 deletions packages/shared/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
],
"scripts": {
"test": "npx jest --ci",
"build-types": "npx tsc --declaration true --emitDeclarationOnly true --declarationDir dist",
"build": "npx tsc",
"clean": "npx tsc --build --clean",
"lint": "npx eslint . --ext .ts",
Expand Down
3 changes: 2 additions & 1 deletion packages/shared/mocks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
],
"scripts": {
"test": "",
"build": "npx tsc",
"build-types": "yarn workspace @launchdarkly/js-sdk-common build-types",
"build": "yarn build-types && npx tsc",
"clean": "npx tsc --build --clean",
"lint": "npx eslint --ext .ts",
"lint:fix": "yarn run lint -- --fix"
Expand Down