Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn topological dev build #291

Conversation

yusinto
Copy link
Contributor

@yusinto yusinto commented Oct 2, 2023

CI failed because yarn workspaces foreach -pR --topological-dev --from '@launchdarkly/xxx' run build. This is because topological-dev instructs yarn to build all deps (prod & dev) prior to running build in the current workspace. Since mocks need types from common this fails.

This pr adds a build-types command to common which gets run prior to mocks build command to ensure common types exist for mocks to be built successfully.

@yusinto yusinto changed the base branch from main to yus/sc-208024/scaffold-js-common-in-js-core October 2, 2023 21:46
@louis-launchdarkly
Copy link
Contributor

@yusinto, the change looks fine to me. Do you expect the build to still have issues?

@kinyoklion
Copy link
Member

I think that the name for build test mocks must have a problem?
image
Showing under cloudflare?

Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should build once it has a typedoc file. Currently all packages expect to build docs.

@@ -1,4 +1,4 @@
name: sdk/cloudflare
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was incorrectly set as cloudflare @louis-launchdarkly . I have fixed this now.

actions/ci/action.yml Outdated Show resolved Hide resolved
actions/ci/action.yml Outdated Show resolved Hide resolved
Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had re-requested changes already, but it looks like my review was re-requested afterward.

Comment on lines +14 to +16
should_build_docs:
description: 'Whether docs should be built. It will be by default.'
default: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested @kinyoklion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish the CI was running for these PRs so I could be sure.

I added a rule that any branch that starts with feat/ will run all checks when PR'd against. When we have cumulative ones like this, we will probably want to leverage that.

As is, I will approve this PR, and then we will need to check that the docs steps are running correctly on the other.

My main apprehension is about the types. I think that it will always be a 'string' in this case and 'true' is what we want. But the builds will tell us for sure.

@yusinto yusinto merged commit b22eef4 into yus/sc-208024/scaffold-js-common-in-js-core Oct 2, 2023
1 check passed
@yusinto yusinto deleted the yus/fix-yarn-topological-dev-build branch October 2, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants