-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yarn topological dev build #291
fix: yarn topological dev build #291
Conversation
@yusinto, the change looks fine to me. Do you expect the build to still have issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should build once it has a typedoc file. Currently all packages expect to build docs.
@@ -1,4 +1,4 @@ | |||
name: sdk/cloudflare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this was incorrectly set as cloudflare @louis-launchdarkly . I have fixed this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had re-requested changes already, but it looks like my review was re-requested afterward.
should_build_docs: | ||
description: 'Whether docs should be built. It will be by default.' | ||
default: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As requested @kinyoklion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really wish the CI was running for these PRs so I could be sure.
I added a rule that any branch that starts with feat/
will run all checks when PR'd against. When we have cumulative ones like this, we will probably want to leverage that.
As is, I will approve this PR, and then we will need to check that the docs steps are running correctly on the other.
My main apprehension is about the types. I think that it will always be a 'string' in this case and 'true' is what we want. But the builds will tell us for sure.
b22eef4
into
yus/sc-208024/scaffold-js-common-in-js-core
CI failed because
yarn workspaces foreach -pR --topological-dev --from '@launchdarkly/xxx' run build
. This is becausetopological-dev
instructs yarn to build all deps (prod & dev) prior to running build in the current workspace. Sincemocks
need types fromcommon
this fails.This pr adds a
build-types
command to common which gets run prior to mocksbuild
command to ensure common types exist for mocks to be built successfully.