This repository has been archived by the owner on May 30, 2024. It is now read-only.
allFlags() no longer returns null when client is offline #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkodumal
reviewed
Dec 21, 2016
| @@ -200,8 +200,7 @@ private void sendFlagRequestEvent(String featureKey, LDUser user, JsonElement va | |||
| @Override | |||
| public Map<String, JsonElement> allFlags(LDUser user) { | |||
| if (isOffline()) { | |||
| logger.warn("allFlags() was called when client is in offline mode! Returning null."); | |||
| return null; | |||
| logger.warn("allFlags() was called when client is in offline mode!"); | |||
There was a problem hiding this comment.
This should probably be info at this point?
There was a problem hiding this comment.
..or debug. If you're here it means you've most likely intentionally set offline to true, and you'll end up with a bunch of these messages in your logs.
|
👍 |
eli-darkly
added a commit
that referenced
this pull request
Jul 17, 2018
avoid unnecessary retry after Redis update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.