Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

LDClient#allFlags should not return null if using TestFeatureStore offline #75

Closed
samhaldane opened this issue Oct 5, 2016 · 8 comments

Comments

@samhaldane
Copy link
Contributor

It would be handy to be able to use the allFlags method in unit tests with TestFeatureStore in offline mode. At the moment the method returns null if the client is in offline mode. Change it to return the result of InMemoryFeatureStore#all in this situation.

@samhaldane
Copy link
Contributor Author

@jkodumal it would be good to get a fix for this one

@jkodumal
Copy link
Contributor

jkodumal commented Dec 8, 2016

@samhaldane On it-- should be a relatively simple one on our end.

@gjoseph
Copy link

gjoseph commented Dec 21, 2016

Hey @jkodumal, any chance for an update on this ?

@drichelson
Copy link
Contributor

@samhaldane #81 should address your request. I've published 2.0.7-SNAPSHOT if you want to take a look right away.

@gjoseph
Copy link

gjoseph commented Dec 22, 2016

FWIW, I tried this (build a snapshot myself as I wasn't sure where to get yours - https://oss.sonatype.org/content/repositories/snapshots didn't have it - and it worked :)
Any ETA on the actual release ?

@drichelson
Copy link
Contributor

HI Sam, We released 2.0.7. Snapshots can be found here: https://oss.sonatype.org/content/groups/public/

@gjoseph
Copy link

gjoseph commented Dec 23, 2016

Sweet, thanks Dan!

@samhaldane
Copy link
Contributor Author

Thanks @drichelson

eli-darkly added a commit that referenced this issue Jun 26, 2018
treat most 4xx errors as unrecoverable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants