This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
LDClient#allFlags should not return null if using TestFeatureStore offline #75
Comments
@jkodumal it would be good to get a fix for this one |
@samhaldane On it-- should be a relatively simple one on our end. |
Hey @jkodumal, any chance for an update on this ? |
@samhaldane #81 should address your request. I've published 2.0.7-SNAPSHOT if you want to take a look right away. |
FWIW, I tried this (build a snapshot myself as I wasn't sure where to get yours - https://oss.sonatype.org/content/repositories/snapshots didn't have it - and it worked :) |
HI Sam, We released 2.0.7. Snapshots can be found here: https://oss.sonatype.org/content/groups/public/ |
Sweet, thanks Dan! |
Thanks @drichelson |
eli-darkly
added a commit
that referenced
this issue
Jun 26, 2018
treat most 4xx errors as unrecoverable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It would be handy to be able to use the allFlags method in unit tests with TestFeatureStore in offline mode. At the moment the method returns null if the client is in offline mode. Change it to return the result of InMemoryFeatureStore#all in this situation.
The text was updated successfully, but these errors were encountered: