Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1905 : replaced all uses of "uri" to "url" #1906

Merged
merged 2 commits into from
Jun 17, 2022
Merged

fix #1905 : replaced all uses of "uri" to "url" #1906

merged 2 commits into from
Jun 17, 2022

Conversation

romsto
Copy link
Contributor

@romsto romsto commented Jun 15, 2022

See #1905

abonander
abonander requested changes Jun 16, 2022
View reviewed changes
sqlx-core/src/mysql/options/parse.rs Outdated Show resolved Hide resolved
@romsto romsto requested a review from abonander June 17, 2022 10:03
@romsto
Copy link
Contributor Author

romsto commented Jun 17, 2022

Sorry I'm quite new to PRs. Going to resolve conflicts

rebase commits
00eb69c 
resolved conflicts in mod.rs

fixed conflict in options.rs

Update options.rs

Update options.rs

Update options.rs
@abonander abonander merged commit adc7bca into launchbadge:main Jun 17, 2022
@abonander
Copy link
Collaborator

Thanks!

abonander pushed a commit that referenced this pull request Jun 17, 2022
@abonander
fix #1905 : replaced all uses of "uri" to "url" (#1906)
339e058 
* fix #1905 : replaced all uses of "uri" to "url"

* rebase commits

resolved conflicts in mod.rs

fixed conflict in options.rs

Update options.rs

Update options.rs

Update options.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonander abonander Awaiting requested review from abonander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romsto @abonander