Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "URL" instead of "URI" everywhere when talking about database URLs #1905

Closed
abonander opened this issue Jun 14, 2022 · 0 comments
Closed
Labels
E-medium good first issue Good for newcomers help wanted Extra attention is needed

Comments

@abonander
Copy link
Collaborator

abonander commented Jun 14, 2022

The use of the term "URI" is discouraged by the WHATWG: https://url.spec.whatwg.org/#goals

Standardize on the term URL. URI and IRI are just confusing. In practice a single algorithm is used for both so keeping them distinct is not helping anyone. URL also easily wins the search result popularity contest.

We already have DATABASE_URL and that's not going anywhere, so using "URI" in other places to refer to the same string format is just unnecessarily confusing.

This should be more or less a trivial find-replace so if someone wants an easy blip on their "Contributions" graph, this is a good issue to tackle. I'm only classifying this E-medium if someone wants to cover the whole repo at once.

@abonander abonander added good first issue Good for newcomers help wanted Extra attention is needed E-medium labels Jun 14, 2022
abonander pushed a commit that referenced this issue Jun 17, 2022
* fix #1905 : replaced all uses of "uri" to "url"

* rebase commits

resolved conflicts in mod.rs

fixed conflict in options.rs

Update options.rs

Update options.rs

Update options.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant