Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool fixes and breaking changes #1901

Merged
merged 1 commit into from
Jun 16, 2022
Merged

pool fixes and breaking changes #1901

merged 1 commit into from
Jun 16, 2022

Conversation

abonander
Copy link
Collaborator

@abonander abonander commented Jun 11, 2022

  • Fixed leak of Arc<SharedPool> in DecrementSizeGuard::cancel()
  • Renamed PoolOptions::connect_timeout to acquire_timeout for clarity.
  • Fixed /* SQLx ping */ showing up in Postgres query logs
  • Made .close() a regular function that returns a Future
  • Deleted deprecated method PoolConnection::release()
  • Document why connection might be dropped if Pool::acquire() is cancelled
  • Added connection metadata to pool lifecycle callbacks
  • Improved guarantees for min_connections
  • Fixed num_idle() to not spin forever at high load
  • Improved documentation across the pool module

Closes #1869
Closes #1862
Closes #1824
Closes #1743
Closes #561

* Fixed leak of `Arc<SharedPool>` in `DecrementSizeGuard::cancel()`
* Renamed `PoolOptions::connect_timeout` to `acquire_timeout` for clarity.
* Fixed `/* SQLx ping */` showing up in Postgres query logs
* Made `.close()` a regular function that returns a `Future`
* Deleted deprecated method `PoolConnection::release()`
* Document why connection might be dropped if `Pool::acquire()` is cancelled
* Added connection metadata to pool lifecycle callbacks
* Improved guarantees for `min_connections`
* Fixed `num_idle()` to not spin forever at high load
* Improved documentation across the `pool` module
@abonander abonander changed the title WIP pool fixes and breaking changes pool fixes and breaking changes Jun 16, 2022
@abonander abonander marked this pull request as ready for review June 16, 2022 19:43
@abonander abonander merged commit f02ff94 into master Jun 16, 2022
@abonander abonander deleted the ab/fix-pool branch June 16, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment