Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SQLx dependency to 0.6.x #808

Closed
3 tasks done
billy1624 opened this issue Jun 21, 2022 · 13 comments · Fixed by #834
Closed
3 tasks done

Upgrade SQLx dependency to 0.6.x #808

billy1624 opened this issue Jun 21, 2022 · 13 comments · Fixed by #834
Assignees
Milestone

Comments

@billy1624
Copy link
Member

billy1624 commented Jun 21, 2022

Motivation

Upgrading SQLx dependency as well as the downstream dependencies such as time, uuid, bigdecimal, etc.

Tasks

Additional Information

Potential Breaking Changes

@billy1624 billy1624 added this to the 0.9.x milestone Jun 21, 2022
@billy1624 billy1624 moved this to Triage in SeaQL Dev Tracker Jun 21, 2022
@billy1624 billy1624 moved this from Triage to Next Up in SeaQL Dev Tracker Jun 21, 2022
@tyt2y3
Copy link
Member

tyt2y3 commented Jun 30, 2022

Is there a PR for this yet?

@billy1624
Copy link
Member Author

No active PR at the moment :P

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 30, 2022

0.9 release definitely depends on this

@Sytten
Copy link
Contributor

Sytten commented Jul 1, 2022

Yeah agreed, needs an update to time. I am wondering if chrono support should be just removed, its basically deprecated.
It's a bit annoying that when using sqlx-postgres, chrono gets added automatically and also the CLI defaults to chrono without a flag for time.

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 2, 2022

Regarding unwanted dependencies, I think we can take advantage of ? dependency and solve that

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 2, 2022

sea-query and sea-schema is already upgraded to sqlx 0.6 and released
@billy1624 sea-orm side can assign to you?
Or you'd need help from Ivan?

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 2, 2022

I am wondering if chrono support should be just removed, its basically deprecated

I also don't oppose to change the default in SeaORM if a lib is deprecated. However is there an authoritative source for this information?

@Sytten
Copy link
Contributor

Sytten commented Jul 2, 2022

Well its not dead but no release in two years and unpatched vulnerability. The current master is very different from the current release. You can keep it with the ? Thats true.

@ikrivosheev
Copy link
Member

ikrivosheev commented Jul 2, 2022

sea-query and sea-schema is already upgraded to sqlx 0.6 and released
@billy1624 sea-orm side can assign to you?
Or you'd need help from Ivan?

@tyt2y3 did you mean me?

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 2, 2022

sea-query and sea-schema is already upgraded to sqlx 0.6 and released
@billy1624 sea-orm side can assign to you?
Or you'd need help from Ivan?

@tyt2y3 did you mean me?

Haha yes

@billy1624
Copy link
Member Author

Yeah agreed, needs an update to time. I am wondering if chrono support should be just removed, its basically deprecated. It's a bit annoying that when using sqlx-postgres, chrono gets added automatically and also the CLI defaults to chrono without a flag for time.

Hey @Sytten, do you mean generate entity with datetime field defined with time types?

@billy1624 billy1624 self-assigned this Jul 3, 2022
@billy1624 billy1624 moved this from Next Up to In Progress in SeaQL Dev Tracker Jul 3, 2022
@billy1624
Copy link
Member Author

sea-query and sea-schema is already upgraded to sqlx 0.6 and released @billy1624 sea-orm side can assign to you? Or you'd need help from Ivan?

Yes, please! I've created a PR for this but it's still WIP. Please check #834 and see if you have anything to add. Just feel free to push commits to the branch.

I'll get back and work on it tomorrow. Thanks! :D

@billy1624
Copy link
Member Author

Hey everyone, #834 is ready for review! :)

@billy1624 billy1624 moved this from In Progress to Review in SeaQL Dev Tracker Jul 4, 2022
@billy1624 billy1624 moved this from Review to Done in SeaQL Dev Tracker Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants