feat(store,world): add errors to IStore, rename error interfaces #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses two issues:
IStore(and thus the downstream generatedIWorld) was missing store error definitions. Because we will useIWorldABI as our typed interface into the world and used to decode errors, we'll need these here.IErrorsinterfaces because forge flattens these ABIs by name, so only one was appearing in the ABI output for a given project using both world and store.Might help with #712 but unclear without a reproduction of the original issue.
There's another issue around user-defined errors/events (#757) that we should address separately but is also needed to ensure our parsing of errors etc. is robust when calling methods on the world.