Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Decode custom errors in forge and client #712

Closed
alvrs opened this issue Apr 10, 2023 · 2 comments
Closed

[CLI] Decode custom errors in forge and client #712

alvrs opened this issue Apr 10, 2023 · 2 comments
Assignees
@holic
Milestone
ETH Global Freeze

Comments

@alvrs
Copy link
Member

alvrs commented Apr 10, 2023 •
edited
Loading

Currently custom errors are not correctly decoded in forge tests or the client, but only surfaced as bytes4 selector
@alvrs alvrs transferred this issue from another repository May 2, 2023
@alvrs alvrs added this to the ETH Global Freeze milestone May 2, 2023
@holic holic mentioned this issue May 8, 2023
Merged
@holic
Copy link
Member

holic commented May 10, 2023

Might be fixed by #767 and #768

@holic
Copy link
Member

holic commented May 11, 2023 •
edited
Loading

I did see a custom error pop up recently in some foundry tests, so I think this is fixed.

Image

@holic holic closed this as completed May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holic holic

Labels
None yet
Projects
No open projects
ETH Global Milestone
Status: Done
Milestone
ETH Global Freeze
Development

No branches or pull requests
2 participants
@holic @alvrs