Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network,recs,std-client): support StoreSetField before StoreSetRecord #581

Merged
merged 1 commit into from
Apr 4, 2023
Merged

feat(network,recs,std-client): support StoreSetField before StoreSetRecord #581

merged 1 commit into from
Apr 4, 2023

Conversation

holic
Copy link
Member

@holic holic commented Apr 3, 2023 •
edited
Loading

closes #479
closes #523

related to #582

@holic holic marked this pull request as ready for review April 3, 2023 23:17
@holic holic requested a review from alvrs as a code owner April 3, 2023 23:17
@holic
Copy link
Member Author

holic commented Apr 3, 2023

I didn't realize I wasn't on a branch and accidentally committed this to main in e9b2fc7 and then reverted in 8c713f7

alvrs
alvrs approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@holic holic merged commit f259f90 into main Apr 4, 2023
@holic holic deleted the holic/store-set-field branch April 4, 2023 16:24
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@holic @alvrs