Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate internals to viem (from ethers) #582

Closed
holic opened this issue Apr 3, 2023 · 2 comments
Closed

Migrate internals to viem (from ethers) #582

holic opened this issue Apr 3, 2023 · 2 comments
Assignees

Comments

@holic
Copy link
Member

holic commented Apr 3, 2023

viem is shaping up to be a rock solid library with incredible benchmarks over ethers. It's strongly typed, well tested, and maps closely to RPC calls and other Ethereum-native operations, and only does what you ask it to (unlike ethers that ends up doing a lot more work than is often necessary, hence benchmarks).

I've already used it in some personal projects and loving the speed/performance + predictability.

Rough plan:

  • Migrate v2 store event decoding to viem
  • Migrate v2 store event ingestion (rpc calls) to viem
    • We'd still lean on ethers providers for v1 things
  • Build new v2 client code on top of viem

In the future:

  • Use viem + wagmi for wallet connection/account delegation (pending wagmi migrating to viem)
@holic holic self-assigned this Apr 3, 2023
@holic holic changed the title migrate store decoding to viem Migrate internals viem (from ethers) Apr 4, 2023
@holic holic changed the title Migrate internals viem (from ethers) Migrate internals to viem (from ethers) Apr 4, 2023
@roninjin10
Copy link
Contributor

I think a good idea here might be to wait til wagmi cli has viem plugin support. Then you will be able to generate viem/wagmi wrappers automatically from the cli for all contracts

@holic
Copy link
Member Author

holic commented Jul 10, 2023

This is ongoing and mostly done, things are looking quite promising! I've finally got a full WIP (#1033) running on just viem + new network packages + store-cache and we can call contracts with viem directly.

@holic holic closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants