Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deploy script to use viem #1006

Closed
alvrs opened this issue Jun 8, 2023 · 1 comment
Closed

Refactor deploy script to use viem #1006

alvrs opened this issue Jun 8, 2023 · 1 comment
Assignees
@holic
Labels
good first issue Good for newcomers
Milestone
MUD v2 stable rel...

Comments

@alvrs
Copy link
Member

alvrs commented Jun 8, 2023

Currently the deploy script is using ethers to send transactions for deploying contracts and registering tables / systems / modules etc.

We're moving towards viem (see #582) and should also use viem instead of ethers here too (eg. for more expressive errors in case a transaction fails).

We should also modularize this script, it's currently pretty spaghetti.
@alvrs alvrs added the good first issue Good for newcomers label Jun 8, 2023
@alvrs alvrs added this to the Contracts stable milestone Jul 12, 2023
This was referenced Sep 6, 2023
Merged
Merged
@alvrs alvrs modified the milestones: Contracts stable, MUD stable Sep 16, 2023
This was referenced Sep 28, 2023
Closed
Closed
@holic
Copy link
Member

holic commented Oct 11, 2023

done in #1702

@holic holic closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holic holic

Labels
good first issue Good for newcomers
Projects
No open projects
Contributors welcome
Status: Done
MUD v2 stable release (deprecated)
Status: Done
Milestone
MUD v2 stable release
Development

Successfully merging a pull request may close this issue.

refactor(cli): replace ethers with viem johngrantuk/mud
2 participants
@holic @alvrs