Revert opcache for CLI #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisnamuliarta
referenced
this pull request
in tisnamuliarta/laravel-shadcn
Mar 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel/sail](https://togithub.com/laravel/sail) | `1.29.0` -> `1.29.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/sail (laravel/sail)</summary> ### [`v1.29.1`](https://togithub.com/laravel/sail/blob/HEAD/CHANGELOG.md#v1291---2024-03-20) [Compare Source](https://togithub.com/laravel/sail/compare/v1.29.0...v1.29.1) - \[1.x] Make commands lazy by [@​timacdonald](https://togithub.com/timacdonald) in [https://github.com/laravel/sail/pull/683](https://togithub.com/laravel/sail/pull/683) - Preinstall nano, so default make tinker edit work out of the box by [@​negoziator](https://togithub.com/negoziator) in [https://github.com/laravel/sail/pull/685](https://togithub.com/laravel/sail/pull/685) - Revert opcache for CLI by [@​driesvints](https://togithub.com/driesvints) in [https://github.com/laravel/sail/pull/684](https://togithub.com/laravel/sail/pull/684) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tisnamuliarta/laravel-shadcn). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had several issues for installing Jetstream, etc because opcache was caching certain files:
laravel/jetstream#1454
laravel/jetstream#1451
laravel/octane#858
@jessarcher has already worked on a potential fix to invalidate the opcache file before installing the provider: laravel/framework#50665
But I feel like the original PR #569 was a mistake (sorry @lukeraymonddowning!) as it's simply not recommended to have opcache enabled on CLI.
People can still enable this on their own if they want to.