[11.x] Fix adding multiple bootstrap providers with opcache #50665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2024
driesvints
approved these changes
Mar 20, 2024
nunomaduro
approved these changes
Mar 20, 2024
This was referenced Jun 4, 2024
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when calling the
ServiceProvider::addProviderToBootstrapFilemethod multiple times with opcache enabled.Currently, subsequent calls to the method will overwrite any changes from previous calls because the
bootstrap/providers.phpfile is cached on the initial read.This was an issue with the Jetstream installer, especially when run inside Sail where opcache is enabled by default.
Fixes laravel/jetstream#1454
Credit and thanks to @nunomaduro for this solution! My alternate idea was a static cache of the providers, but I prefer this one.