Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to PHPUnit 6 #557

Closed
wants to merge 2 commits into from
Closed

Updated to PHPUnit 6 #557

wants to merge 2 commits into from

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Nov 2, 2017 •
edited
Loading

Updated phpunit/phpunit to ~6.0.

Should we drop support to PHP 5.6, as PHPUnit 6.0 requires PHP 7.0?

PS: I've used this commit from laravel/framework to prevent failed tests.

@taylorotwell
Copy link
Member

Tests fail.

@carusogabriel
Copy link
Contributor Author

carusogabriel commented Nov 2, 2017 •
edited
Loading

@taylorotwell The tests only failed because of PHPUnit 6.0 requires PHP 7.0. Should we drop support to 5.6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carusogabriel @taylorotwell