[5.5] Be less strict for risky tests in PHPUnit 6. #17864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmichot
changed the title
|
👎 Tests should instead be annotated with the has no assertions annotation. |
|
No, annotating all these tests would result in a too big PR to review, that would not be merged anyway |
|
Would be easy to review. |
This was referenced Nov 2, 2017
|
@GrahamCampbell What annotation you were talking about? I need it, but can't find 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPunit 6 echoes all risky tests for not actually testing anything. This turns the output into something very unfriendly:
This PR allows not to display them.